feat: add agent scorer authoring#317
Conversation
|
Nice work getting this out — the shape is right and the XML matches what the org expects. A few things I'd like to see addressed before we approve; the top three are library-level correctness issues that let Blocking
validateScorerSpec({ dataType: 'Number', ...no specification... }) → no throw buildScorerXml then produces a Number scorer with zero entries and no block. Add: if (spec.dataType === 'Number' && !spec.specification) {
validateScorerSpec({ dataType: 'LightningType', lightningType: 'bogus__type', ... }) → no throw The CLI's JSON schema catches this today, but library-only callers get no protection. Please cross-check against the const you already export.
The Number branch always regenerates enum values from specification and ignores anything the caller passed in outputEnumValues. Either reject the combination in validateScorerSpec (mutually exclusive) or honor Should fix
Nice-to-have
|
What does this PR do?
Add core logic for generating the AiAgentScorerDefinition metadata
What issues does this PR fix or reference?
new feature