FD-773: render a password form for password-protected collections#3
Open
tomconroy wants to merge 2 commits into
Open
FD-773: render a password form for password-protected collections#3tomconroy wants to merge 2 commits into
tomconroy wants to merge 2 commits into
Conversation
Catch FontduePasswordProtectedError in the loader and render <NodePasswordForm> instead of a 404. The root runWithPreview middleware already forwards the visitor's node-access token and its no-store rewrite supersedes the route's cache headers, so no cache change is needed here. Requires the FD-773 fontdue-js release; pair with the version bump. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
❌ Deploy Preview for fontdue-example-react-router failed.
|
Mount runWithFontdue (from fontdue-js/server/middleware) in the root-route middleware in place of runWithPreview: it forwards the admin preview token AND the visitor's per-collection node-access token into the ambient render context, and forces a per-visitor response out of the CDN cache. runWithPreview now forwards only the preview token, so the unlock needs runWithFontdue. Requires the fontdue-js FD-773 release. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catch
FontduePasswordProtectedErrorin the font loader and render<NodePasswordForm>instead of a 404.The root
runWithPreviewmiddleware already forwards the visitor's node-access token, and itsno-storerewrite supersedes the route's cache headers, so no cache change is needed here.Requires the FD-773 fontdue-js release — pair with the version bump. Backend: fontdue/fontage#1111.
FD-773
🤖 Generated with Claude Code