Add preemptive instance request fields to server#56
Open
DigitallyBorn wants to merge 3 commits intofog:masterfrom
Open
Add preemptive instance request fields to server#56DigitallyBorn wants to merge 3 commits intofog:masterfrom
DigitallyBorn wants to merge 3 commits intofog:masterfrom
Conversation
This is likely a breaking bug fix, since requests will now _correctly_ parse the response body as json and return a hash, instead of returning the body as a string. Fixes fog#34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to adding the preemptive instance fields (aka spot instance), I simplified the url/parameter building a little bit to make it easier to read/expand.
There was also a bug detecting the content type. Fixing that allowed the fog-core library to automatically deserialize some responses, so we don't have to explicitly decode responses here anymore.
Also, claiming a little credit for myself for bragging rights.