Fix utf8 display width - #4890
Closed
Satyakam-Mishra wants to merge 4 commits into
Closed
Conversation
vitaut
requested changes
Aug 24, 2026
vitaut
left a comment
Contributor
There was a problem hiding this comment.
Please don't add new headers.
Author
|
Thank you, I have removed the separate unicode_width_table.h header and moved the unicode with table to format.h as suggested. I have also rerun the tests and it still passes. Pushing the update now. |
Contributor
|
Closing in favor of #4896 but thanks anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes incorrect display width calculation for UTF-8 characters in formatted
strings.
Characters with East Asian Width properties
WandFare treated asdouble-width when calculating display width. The implementation uses a binary
search over a generated Unicode range table.
This fixes alignment issues for characters such as emoji and CJK characters.
Regional Indicator symbols are not included as double-width ranges, so flag
sequences such as 🇺🇸 are handled correctly.
Testing
Added regression tests covering:
All tests pass:
git diff --checkpasses