Libcxx transitive include change fix#4855
Open
mccakit wants to merge 4 commits into
Open
Conversation
vitaut
requested changes
Jul 17, 2026
vitaut
left a comment
vitaut
left a comment
Contributor
There was a problem hiding this comment.
Looks good but please fix the lint.
Contributor
|
Looks like the actual fix is gone and there are some unrelated changes in the PR? |
Contributor
Author
Indeed, I'll ping you once I get it working |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLVM 23 depracated libc++ transitive includes, as so needs to be included directly at fmt module interface file rather than coming from a another libc++ header.