Prepare use of import std;#4848
Closed
ClausKlein wants to merge 8 commits into
Closed
Conversation
The fmt project use CXX and CC
ClausKlein
force-pushed
the
feature/add-import-std
branch
from
July 13, 2026 18:06
eaebdb4 to
09d5278
Compare
ClausKlein
marked this pull request as draft
July 13, 2026 18:34
Contributor
Author
|
@vitaut is clang++-3.6 really needed on CI? |
ClausKlein
commented
Jul 13, 2026
| export CC="${CXX/clang++/clang}" | ||
| ;; | ||
| esac | ||
| echo "CC=$CC" |
Contributor
Author
There was a problem hiding this comment.
CI used the default $CC compiler until now?
ClausKlein
force-pushed
the
feature/add-import-std
branch
from
July 13, 2026 21:42
fbbcbd6 to
e424a93
Compare
ClausKlein
marked this pull request as ready for review
July 13, 2026 21:49
ClausKlein
commented
Jul 13, 2026
| strategy: | ||
| matrix: | ||
| cxx: [g++-4.9, g++-11, clang++-3.6, clang++-11] | ||
| cxx: [g++-4.9, g++-11, clang++-11] |
Contributor
Author
There was a problem hiding this comment.
with clang-11 compiler fails the ci build job!
ClausKlein
commented
Jul 14, 2026
| project(fmt-test) | ||
| project(fmt-test CXX) | ||
|
|
||
| find_package(FMT REQUIRED) |
Contributor
Author
There was a problem hiding this comment.
Contributor
|
Thanks, but this PR mixes several unrelated changes and breaks supported configurations, including older CMake versions. It also removes required component validation and does not add CI coverage for the new mode. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested only on OSX with g++-16 and CMake v4.4
use GNUmakefile as usage hint.
This would fix following issues: