Negative integral to char overflow Fix#4840
Open
dxchel wants to merge 3 commits into
Open
Conversation
std::format uses the two's complement for formatting while FML used the absolute value, failing to correctly write when using values like -104 (FMT used 104 while std uses 152)
Checks for int(-136) which on two's complement should be 'x'
dxchel
force-pushed
the
dxchel/integral_to_char_overflow
branch
from
d759a4f to
a612e33
Compare
Now using logic operators instead of bit shifting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4839
Fixed the negative integral overflow issue and added a test to check for 'x' in two's complement