fix(launchplan): show every launch plan - #923
Open
1fanwang wants to merge 2 commits into
Open
Conversation
1fanwang
force-pushed
the
fix-launchplan-count-typo
branch
from
June 21, 2026 08:41
3c7258b to
9bbe292
Compare
1fanwang
changed the title
The launch plan table and card views virtualized against
document.getElementById('scroll-element'), which is null in this layout, so the
virtualizer had no scroll container and rendered the wrong number of rows. The
table view also read result?.length (the lodash `result` function, always
truthy) instead of results?.length. Render the results directly with stable keys.
Signed-off-by: 1fanwang <1fannnw@gmail.com>
The fix changes both launch-plan views, but the regression covered only the table. Exercise the card view with enough results to fail under the old detached virtualizer. Signed-off-by: 1fanwang <1fannnw@gmail.com>
1fanwang
force-pushed
the
fix-launchplan-count-typo
branch
from
August 24, 2026 10:25
9bbe292 to
8795275
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Projects with more than about 30 launch plans cannot reach the rest of the list.
Before this change, a project with 64 launch plans stops scrolling around row 30.
After this change, both list views render through the final launch plan.
Type
Are all requirements met?
Complete description
The virtualizer never receives the page's scroll container, so it renders only its
first window. Render the launch-plan results directly in the card and table views.
Manual check:
Before this change, both views stop around row 30. With this change, both reach row 64.
Regression tests check that every supplied result becomes a table row or card.
Tracking Issue
N/A
Follow-up issue
N/A