fix(launch): render object map values as JSON on relaunch - #922
Open
1fanwang wants to merge 2 commits into
Open
Conversation
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
1fanwang
changed the title
…relaunch A map whose values are objects (e.g. Map[str, Struct]) parsed each value into the string-typed value field, so the launch form bound an object straight into a text input -- coerced to "[object Object]" and producing render errors on relaunch. JSON-stringify object values at parse time so the field always receives a string. Signed-off-by: 1fanwang <1fannnw@gmail.com>
The test name and assertions already carry the relaunch scenario. Repeating the same behavior in source and test comments adds noise without documenting another constraint. Signed-off-by: 1fanwang <1fannnw@gmail.com>
1fanwang
force-pushed
the
fix-mapinput-object-render
branch
from
August 24, 2026 10:14
a7c1cc5 to
2dea5d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Relaunching an execution with object values in a map breaks the launch form.
Before this change, each object renders as
[object Object], validation fails, andLaunch is disabled. After this change, object values render as JSON and the execution
can be launched again.
Type
Are all requirements met?
Complete description
Convert object map values to JSON strings at the form boundary. Plain string and
number values keep their existing representation.
Manual check:
Before this change, the field shows
[object Object]and Launch is disabled. With thischange, the field shows JSON and Launch succeeds. Regression tests cover object and
string values.
Tracking Issue
N/A
Follow-up issue
N/A