Execute admitted data-only operations in Echo#683
Conversation
Strict self-review result@codex please confirm the reviewed boundary and the absence of unresolved findings.
Resolved findings:
Each correction is in a new commit. The final tree is clean; full PR preflight and the normal pre-push hook pass. No unresolved self-review findings remain. |
|
Warning Review limit reached
Next review available in: 13 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (6)
📒 Files selected for processing (14)
📝 WalkthroughWalkthroughAdds a hook-free executable-operation runtime slice with canonical artifacts, admission, bounded private evaluation, typed commit evidence, WAL persistence and recovery, engine registration, end-to-end tests, feature wiring, and documentation updates. ChangesExecutable Operation Runtime
Estimated code review effort: 5 (Critical) | ~120 minutes Sequence Diagram(s)sequenceDiagram
participant Caller
participant TrustedRuntimeHost
participant echo_operation
participant Engine
participant TrustedRuntimeWal
Caller->>TrustedRuntimeHost: submit package and invocation
TrustedRuntimeHost->>echo_operation: admit and prepare operation
echo_operation->>Engine: resolve installed package and basis
echo_operation-->>TrustedRuntimeHost: prepared patch or typed noncommit evidence
TrustedRuntimeHost->>TrustedRuntimeWal: record installation or committed tick
TrustedRuntimeWal-->>TrustedRuntimeHost: recover receipts and installations
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
CI correction pushed in The failed documentation truth gate required an obsolete single-pipeline sentence. The README now names three distinct current corridors—Wesley compatibility, Edict provider-v1 compatibility, and the hook-free executable-operation runtime—and the truth test rejects their recombination. It also qualifies deterministic consequences under callback compatibility. The focused truth test, shell syntax, Prettier, markdownlint, dead-reference gate, PR preflight, and normal pre-push hook pass locally. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/verify-local.sh`:
- Around line 1414-1421: Add the missing
warp-core:installed_contract_registry_tests case to
pre_push_feature_string_for_test_target(), mapping it to the
native_rule_bootstrap feature required by the test. Ensure
warp_core_feature_args_for_test() receives that feature through the existing
shared feature-map flow instead of falling back to an empty string.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: a8b06115-002c-4567-9ddb-997e270e5c0c
⛔ Files ignored due to path filters (2)
Cargo.lockis excluded by!**/*.locktests/edict-provider-host-v1/Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (16)
.ban-nondeterminism-allowlistCHANGELOG.mdREADME.mdcrates/warp-core/Cargo.tomlcrates/warp-core/src/causal_wal.rscrates/warp-core/src/echo_operation.rscrates/warp-core/src/engine_impl.rscrates/warp-core/src/evidence.rscrates/warp-core/src/lib.rscrates/warp-core/src/trusted_runtime_host.rscrates/warp-core/tests/executable_operation_pipeline_tests.rsdocs/architecture/application-contract-hosting.mddocs/plans/2026-07-18-jim-edict-echo-executable-warp-semantics.mddocs/topics/GeneratedRules.mddocs/topics/WAL.mdscripts/verify-local.sh
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 349cf04fa8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
CI follow-up: commit |
1 participant
Claim
Echo can admit, install, privately evaluate, exactly commit, receipt, persist, and recover one data-only executable operation without obtaining application semantics from a matcher, executor, footprint callback, prebuilt mutation plan, or native application intrinsic.
Architectural boundary
This adds an operation-oriented corridor alongside stable provider v1 compatibility infrastructure:
The first program is a generic anchored typed-node alpha-attachment compare-and-set. It is deliberately not Jedit ReplaceRange, a rope intrinsic, provider v2, a general VM, or the Kitten runtime.
A program digest is subordinate executable evidence only. The admitted package owns the public operation coordinate, semantic closure, schemas, basis contract, budget, authority profile, result and obstruction interpretation, and invocability. A naked program cannot be installed or invoked, and identical program bytes in distinct admitted packages do not collapse their operation identities.
What changed
Verification grades
Evidence
cargo xtask pr-preflight --base origin/main: pass, 6 checks.warp-corelibrary suite: 670 passed.warp-corelibrary suite: 684 passed.Explicit non-goals and remaining gates
native_rule_bootstrap; that compile-time coupling must be removed before the Jedit production cutover can delete the legacy feature.Self-review
The strict review found and corrected four defects before publication: asymmetric public encoder/decoder validation for programs, asymmetric invocation-budget validation, incomplete footprint hashing, and wording that could imply noncommitted outcomes entered the WAL. The initial push then exposed and corrected a feature-selection defect in the pre-push hook. No unresolved self-review findings remain.
Summary by CodeRabbit
New Features
Documentation
Tests