Skip to content

Update Polish translation#1525

Open
dawkagaming wants to merge 2 commits intoflxzt:mainfrom
dawkagaming:main
Open

Update Polish translation#1525
dawkagaming wants to merge 2 commits intoflxzt:mainfrom
dawkagaming:main

Conversation

@dawkagaming
Copy link
Copy Markdown

Hello,
I made some updates to pl.po by adding a few new messages and making slight modifications.

Hello,
I made some updates to pl.po by adding a few new messages and making slight modifications.
Comment thread crates/rnote-ui/po/pl.po
#: crates/rnote-ui/src/dialogs/export.rs:1205
msgid "Jpeg"
msgstr "Jpeg"
msgstr "JPEG"
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've opted to capitalize these acronyms.
It could be discussed if it makes sense but from a consistency point of view
it makes sense to stick with what the source string dictates.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, but when I was thinking about it, in polish it looks a bit weird to have acronyms not in capital letter.
Of course, I can edit it if needed.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about changing this? We can discuss and change the capitalization later, but then it would be a change for all languages.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dawkagaming friendly ping! otherwise it will get stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants