Skip to content

Improve error message for invalid Helm chart repository URLs #2063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ogulcanaydogan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve error message for invalid Helm chart repository URLs #2063

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions internal/controller/helmrepository_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ func (r *HelmRepositoryReconciler) reconcileSource(ctx context.Context, sp *patc
// Fetch the repository index from remote.
if err := newChartRepo.CacheIndex(); err != nil {
e := serror.NewGeneric(
fmt.Errorf("failed to fetch Helm repository index: %w", err),
invalidChartRepoError(obj.Spec.URL, err),
meta.FailedReason,
)
conditions.MarkTrue(obj, sourcev1.FetchFailedCondition, e.Reason, "%s", e)
Expand All @@ -476,7 +476,7 @@ func (r *HelmRepositoryReconciler) reconcileSource(ctx context.Context, sp *patc
// Load the cached repository index to ensure it passes validation.
if err := chartRepo.LoadFromPath(); err != nil {
e := serror.NewGeneric(
fmt.Errorf("failed to load Helm repository from index YAML: %w", err),
invalidChartRepoError(obj.Spec.URL, err),
sourcev1.IndexationFailedReason,
)
conditions.MarkTrue(obj, sourcev1.FetchFailedCondition, e.Reason, "%s", e)
Expand Down Expand Up @@ -723,3 +723,10 @@ func (r *HelmRepositoryReconciler) migrationToStatic(ctx context.Context, sp *pa

return ctrl.Result{}, nil
}

// invalidChartRepoError formats an error indicating the given URL is not
// a valid Helm chart repository or cannot be reached, mirroring the
// `helm repo add` CLI output.
func invalidChartRepoError(repoURL string, err error) error {
return fmt.Errorf("looks like %q is not a valid chart repository or cannot be reached: %w", repoURL, err)
}