refactor(api): migrate DependencyReference to shared apis/meta type#1656
Draft
vecil wants to merge 1 commit into
Draft
refactor(api): migrate DependencyReference to shared apis/meta type#1656vecil wants to merge 1 commit into
vecil wants to merge 1 commit into
Conversation
Signed-off-by: Vincent Dely <vincent.dely@ik.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the local
DependencyReferencetype with the sharedmeta.DependencyReferencefromapis/meta, removing the duplicated definition across Applier APIs.Changes
DependencyReferencestruct withtype DependencyReference = meta.DependencyReferencereplacedirectives once fluxcd/pkg releases with the changeMotivation
DependencyReferencewas duplicated across KC and HC APIs. Centralizing it inapis/metaremoves duplication and enables consistent dependency handling, including CEL-based readiness expressions.Notes
go.modandapi/go.modto be removed oncefluxcd/pkgreleases with the change (xref: refactor: move DependencyReference to apis/meta pkg#1212).