-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Updates impeller page to mention desktop compatibility. #13635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -88,24 +88,60 @@ It might use Impeller in the future. | |||||||||
|
|
||||||||||
| ### macOS | ||||||||||
|
|
||||||||||
| You can try out Impeller for macOS behind a flag. | ||||||||||
| In a future release, the ability to opt-out of | ||||||||||
| using Impeller will be removed. | ||||||||||
| Impeller is **available and enabled by default on Flutter 3.47**. In a future | ||||||||||
| release, the ability to opt-out of using Impeller will be removed. | ||||||||||
|
|
||||||||||
| To enable Impeller on macOS when debugging, | ||||||||||
| pass `--enable-impeller` to the `flutter run` command. | ||||||||||
| To disable Impeller on macOS when debugging, pass `--no-enable-impeller` to the | ||||||||||
| `flutter run` command. | ||||||||||
|
|
||||||||||
| ```console | ||||||||||
| flutter run --enable-impeller | ||||||||||
| flutter run --no-enable-impeller | ||||||||||
| ``` | ||||||||||
|
|
||||||||||
| To enable Impeller on macOS when deploying your app, | ||||||||||
| add the following tags under the top-level | ||||||||||
| `<dict>` tag in your app's `Info.plist` file. | ||||||||||
| To disable Impeller on macOS when deploying your app, add the following tags | ||||||||||
| under the top-level `<dict>` tag in your app's `Info.plist` file. | ||||||||||
|
|
||||||||||
| ```xml | ||||||||||
| <key>FLTEnableImpeller</key> | ||||||||||
| <true /> | ||||||||||
| <false /> | ||||||||||
| ``` | ||||||||||
|
|
||||||||||
| ### Linux | ||||||||||
|
|
||||||||||
| Impeller is **available and enabled by default on Flutter 3.47**. In a future | ||||||||||
| release, the ability to opt-out of using Impeller will be removed. | ||||||||||
|
Comment on lines
+111
to
+112
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
|
|
||||||||||
| To disable Impeller on Linux when debugging, pass `--no-enable-impeller` to the | ||||||||||
| `flutter run` command. | ||||||||||
|
|
||||||||||
| ```console | ||||||||||
| flutter run --no-enable-impeller | ||||||||||
| ``` | ||||||||||
|
|
||||||||||
| To disable Impeller on Linux when deploying your app, add the following setup to | ||||||||||
| your project in `linux/runner/my_application.cc`. | ||||||||||
|
|
||||||||||
| ```c | ||||||||||
| fl_dart_project_set_enable_impeller(project, FALSE); | ||||||||||
| ``` | ||||||||||
|
Comment on lines
+121
to
+126
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add extra context on where in the file? Either by explaining it with prose or adding some of the surrounding code to the code block.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe: g_autoptr(FlDartProject) project = fl_dart_project_new();
fl_dart_project_set_dart_entrypoint_arguments(project, self->dart_entrypoint_arguments);
+ fl_dart_project_set_enable_impeller(project, FALSE); |
||||||||||
|
|
||||||||||
| ### Windows | ||||||||||
|
|
||||||||||
| Impeller is **available and enabled by default on Flutter 3.47**. In a future | ||||||||||
| release, the ability to opt-out of using Impeller will be removed. | ||||||||||
|
Comment on lines
+130
to
+131
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
|
|
||||||||||
| To disable Impeller on Windows when debugging, pass `--no-enable-impeller` to the | ||||||||||
| `flutter run` command. | ||||||||||
|
|
||||||||||
| ```console | ||||||||||
| flutter run --no-enable-impeller | ||||||||||
| ``` | ||||||||||
|
|
||||||||||
| To disable Impeller on Windows when deploying your app, add the following setup to | ||||||||||
| your project in `windows\runner\main.cpp`. | ||||||||||
|
|
||||||||||
| ```c++ | ||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
| project.set_impeller_switch(flutter::ImpellerSwitch::Disabled); | ||||||||||
| ``` | ||||||||||
|
Comment on lines
+140
to
145
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add extra context on where in the file? Either by explaining it with prose or adding some of the surrounding code to the code block.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe: flutter::DartProject project(L"data");
std::vector<std::string> command_line_arguments =
GetCommandLineArguments();
project.set_dart_entrypoint_arguments(std::move(command_line_arguments));
+ project.set_impeller_switch(flutter::ImpellerSwitch::Disabled); |
||||||||||
|
|
||||||||||
| ### Bugs and issues | ||||||||||
|
|
||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Opt out" doesn't need a hyphen when it's used as a verb: