fix: action lookup stops when matching action has isEnabled set to false#13516
Open
pathconnected wants to merge 1 commit into
Open
fix: action lookup stops when matching action has isEnabled set to false#13516pathconnected wants to merge 1 commit into
pathconnected wants to merge 1 commit into
Conversation
Collaborator
|
Staged preview of the updated docs.flutter.dev site (updated for commit d6c19e0): https://flutter-docs-prod--docs-pr13516-fix-intent-bubbling-wh-ncv1bvjb.web.app |
Collaborator
|
Staged preview of the updated flutter.dev site (updated for commit d6c19e0): https://flutter-dev-230821--www-pr13516-fix-intent-bubbling-wh-k728ogi0.web.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix site documentation's note on what happens when an action's
isEnabledis set to false. The documentation said that search for a matching action continues up in the tree, but it actually stops.Relevant source code:
The
maybeFind(second one) is the one used by shortcuts (per shortcuts.dart#L922-L938).A side example:
DismissIntentfrom modals is handled by_DismissModalAction(routes.dart#L975-L984), andisEnabledis set to false if the modal is notbarrierDismissible. Actions that handle the dismiss intent above in the widget tree do not get invoked in that case.Presubmit checklist
of 80 characters or fewer.