Skip to content

fix: action lookup stops when matching action has isEnabled set to false#13516

Open
pathconnected wants to merge 1 commit into
flutter:mainfrom
pathconnected:fix/intent-bubbling-when-action-not-enabled
Open

fix: action lookup stops when matching action has isEnabled set to false#13516
pathconnected wants to merge 1 commit into
flutter:mainfrom
pathconnected:fix/intent-bubbling-when-action-not-enabled

Conversation

@pathconnected

@pathconnected pathconnected commented Jun 17, 2026

Copy link
Copy Markdown

Fix site documentation's note on what happens when an action's isEnabled is set to false. The documentation said that search for a matching action continues up in the tree, but it actually stops.

Relevant source code:

The maybeFind (second one) is the one used by shortcuts (per shortcuts.dart#L922-L938).

A side example: DismissIntent from modals is handled by _DismissModalAction (routes.dart#L975-L984), and isEnabled is set to false if the modal is not barrierDismissible. Actions that handle the dismiss intent above in the widget tree do not get invoked in that case.

Presubmit checklist

  • If you are unwilling, or unable, to sign the CLA, even for a tiny, one-word PR, please file an issue instead of a PR.
  • If this PR is not meant to land until a future stable release, mark it as draft with an explanation.
  • This PR follows the Google Developer Documentation Style Guidelines—for example, it doesn't use i.e. or e.g., and it avoids I and we (first-person pronouns).
  • This PR uses semantic line breaks
    of 80 characters or fewer.

@pathconnected pathconnected requested review from a team and sfshaza2 as code owners June 17, 2026 22:07
gemini-code-assist[bot]

This comment was marked as resolved.

@flutter-website-bot

Copy link
Copy Markdown
Collaborator

Staged preview of the updated docs.flutter.dev site (updated for commit d6c19e0):

https://flutter-docs-prod--docs-pr13516-fix-intent-bubbling-wh-ncv1bvjb.web.app

@flutter-website-bot

Copy link
Copy Markdown
Collaborator

Staged preview of the updated flutter.dev site (updated for commit d6c19e0):

https://flutter-dev-230821--www-pr13516-fix-intent-bubbling-wh-k728ogi0.web.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants