Skip to content

Clarify Android ABI filtering guidance#13514

Merged
sfshaza2 merged 1 commit into
flutter:mainfrom
danyalahmed1995:docs/android-abi-filtering-guidance
Jun 18, 2026
Merged

Clarify Android ABI filtering guidance#13514
sfshaza2 merged 1 commit into
flutter:mainfrom
danyalahmed1995:docs/android-abi-filtering-guidance

Conversation

@danyalahmed1995

Copy link
Copy Markdown
Contributor

Description of what this PR is changing or adding, and why:

Updates the Android ABI filtering guidance to clarify when -Pdisable-abi-filtering=true is required.

The docs now distinguish between ABI filters configured in defaultConfig, which can be preserved automatically, and ABI filters configured under buildTypes or productFlavors, which require disabling Flutter's default ABI filtering.

Issues fixed by this PR (if any):

Clarifies guidance discussed in flutter/flutter#188009.

PRs or commits this PR depends on (if any):

Related to flutter/flutter#177753 and flutter/flutter#181828.

Presubmit checklist

@danyalahmed1995 danyalahmed1995 requested review from a team and sfshaza2 as code owners June 17, 2026 18:46

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation regarding Android ABI filtering in Flutter, advising developers to configure abiFilters in defaultConfig rather than buildTypes or productFlavors, and updating the flag usage to -Pdisable-abi-filtering=true. The feedback suggests using a nested ndk block in the Kotlin DSL code example to make it more idiomatic and readable.

@danyalahmed1995 danyalahmed1995 force-pushed the docs/android-abi-filtering-guidance branch from 6547f1a to 8ebd714 Compare June 17, 2026 21:19
@parlough

Copy link
Copy Markdown
Member

/gcbrun

@flutter-website-bot

Copy link
Copy Markdown
Collaborator

Staged preview of the updated docs.flutter.dev site (updated for commit 8ebd714):

https://flutter-docs-prod--docs-pr13514-docs-android-abi-filte-s2iuoknx.web.app

@flutter-website-bot

Copy link
Copy Markdown
Collaborator

Staged preview of the updated flutter.dev site (updated for commit 8ebd714):

https://flutter-dev-230821--www-pr13514-docs-android-abi-filte-2yvdpns8.web.app

@sfshaza2 sfshaza2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@sfshaza2 sfshaza2 merged commit 7121fc2 into flutter:main Jun 18, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants