Use ID of operating sysems instead of name in selectors#13506
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the OsSelector component to use os.id instead of os.name for CSS classes, element IDs, and data attributes. The review feedback highlights a variable shadowing issue where the loop variable os shadows the method parameter os, which could cause confusion, and suggests renaming the loop variable to improve code readability.
Collaborator
|
Staged preview of the updated docs.flutter.dev site (updated for commit a6a1f58): https://flutter-docs-prod--docs-pr13506-fix-os-selector-ids-5rqp5zfu.web.app |
Collaborator
|
Staged preview of the updated flutter.dev site (updated for commit a6a1f58): https://flutter-dev-230821--www-pr13506-fix-os-selector-ids-v5uw3es9.web.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the OS selector on pages such as https://docs.flutter.dev/install/manual page after I didn't account for the changes to
OperatingSystem.namein 156b8c3.Staged: https://flutter-docs-prod--docs-pr13506-fix-os-selector-ids-5rqp5zfu.web.app/install/manual