Skip to content

Adding a staging skill#13166

Open
sfshaza2 wants to merge 4 commits intomainfrom
staging-site-skill
Open

Adding a staging skill#13166
sfshaza2 wants to merge 4 commits intomainfrom
staging-site-skill

Conversation

@sfshaza2
Copy link
Contributor

As it says

@sfshaza2 sfshaza2 requested review from antfitch and parlough March 11, 2026 18:37
@sfshaza2 sfshaza2 requested a review from a team as a code owner March 11, 2026 18:37
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new skill for staging the Flutter site. The instructions are clear overall, but I have a couple of suggestions to improve the clarity and logical flow of the steps. Specifically, I recommend reordering the staging steps to ensure validation happens on the latest content, and clarifying the usage of the two different link-checking commands.

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Mar 11, 2026

Visit the preview URL for this PR (updated for commit bb9f62f):

https://flutter-docs-prod--pr13166-staging-site-skill-0ay604fs.web.app

Copy link
Member

@parlough parlough Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should consider a different name and description for this skill? It slightly conflates the meaning of the word "staging": what the skill discusses and then its step 4, which is also staging the site. I wonder that could be a bit confusing.

Would this skill be better described as something like "Validate(or check?) your changes [to the site] [before committing]"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants