Docs: Clarify native code placement in Flutter modules #12968
Conversation
Summary of ChangesHello @sfshaza2, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the clarity of the Flutter documentation regarding the integration of Flutter modules into Android applications. The primary goal is to prevent developers from incorrectly placing native code within the ephemeral Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request significantly improves the documentation by clarifying where to place native code in Flutter modules. The new warning block is much clearer and more direct than the previous note, effectively highlighting a common pitfall for developers. The guidance on using plugins for module-specific code and the host app for app-specific code is excellent. The added explanation about the .android directory's purpose and its use of Java is also very helpful. Overall, this is a high-quality documentation update.
|
Visit the preview URL for this PR (updated for commit e50d50e): https://flutter-docs-prod--pr12968-fix-issue-12960-native-code-ohpeimeg.web.app |
camsim99
left a comment
camsim99
left a comment
There was a problem hiding this comment.
LGTM :) just left two wording suggestions
Co-authored-by: Camille Simon <43054281+camsim99@users.noreply.github.com>
_Description of what this PR is changing or adding, and why:_ This adds the new compressed rules files to our docs page. (flutter/flutter#179817) _Issues fixed by this PR (if any):_ _PRs or commits this PR depends on (if any):_ ## Presubmit checklist - [x] If you are unwilling, or unable, to sign the CLA, even for a _tiny_, one-word PR, please file an issue instead of a PR. - [x] If this PR is not meant to land until a future stable release, mark it as draft with an explanation. - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style)—for example, it doesn't use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first-person pronouns). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer. --------- Co-authored-by: Shams Zakhour <44418985+sfshaza2@users.noreply.github.com>
5 participants
Fixes #12960. Clarifies that the .android folder is ephemeral and that native code should be placed in Plugins or the Host App.