-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[video_player_android] allow supplying a custom VideoAsset #12491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
a1rwulf
wants to merge
1
commit into
flutter:main
Choose a base branch
from
a1rwulf:upstream_video-asset-provider-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
...ayer_android/android/src/main/java/io/flutter/plugins/videoplayer/VideoAssetProvider.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| // Copyright 2013 The Flutter Authors | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| package io.flutter.plugins.videoplayer; | ||
|
|
||
| import android.content.Context; | ||
| import androidx.annotation.NonNull; | ||
| import androidx.annotation.Nullable; | ||
|
|
||
| /** | ||
| * Supplies a {@link VideoAsset} for a URI, overriding this plugin's default handling. | ||
| * | ||
| * <p>This is the extension point for playback that the plugin cannot express on its own, such as | ||
| * reading from a download or HTTP cache, applying a custom {@code DataSource.Factory}, or resolving | ||
| * a scheme this plugin does not know about. Because {@link VideoAsset} already exposes the media | ||
| * item and media source factory, an implementation has full control over how a URI is played | ||
| * without this plugin needing to know why. | ||
| * | ||
| * <p>Register with {@link VideoPlayerPlugin#setVideoAssetProvider}. At most one provider is active | ||
| * at a time; the last one registered wins. | ||
| */ | ||
| public interface VideoAssetProvider { | ||
| /** | ||
| * Returns the asset to play for {@code uri}, or null to use this plugin's default handling. | ||
| * | ||
| * <p>Called on the main thread each time a player is created, before the URI is inspected for a | ||
| * known scheme, so a provider may override any URI including {@code asset:} and {@code rtsp:} | ||
| * ones. | ||
| * | ||
| * @param context application context. | ||
| * @param uri the URI the player was created with. | ||
| * @return the asset to play, or null to fall through to the default. | ||
| */ | ||
| @Nullable | ||
| VideoAsset getAsset(@NonNull Context context, @NonNull String uri); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since
videoAssetProvideris a static field that can be set from any thread (e.g., during background initialization or dependency injection) and read on the main thread, it should be marked asvolatileto ensure thread visibility and prevent stale reads.