-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[google_fonts] support material ui #12489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ name: google_fonts | |
| description: A Flutter package to use fonts from fonts.google.com. Supports HTTP fetching, caching, and asset bundling. | ||
| repository: https://github.com/flutter/packages/tree/main/packages/google_fonts | ||
| issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+google_fonts%22 | ||
| version: 8.2.1 | ||
| version: 8.2.2 | ||
|
|
||
| environment: | ||
| sdk: ^3.10.0 | ||
|
|
@@ -13,9 +13,11 @@ dependencies: | |
| flutter: | ||
| sdk: flutter | ||
| http: ^1.0.0 | ||
| material_ui: ^1.0.0 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Replacing the standard Flutter SDK dependency with the external |
||
| path_provider: ^2.0.0 | ||
|
|
||
| dev_dependencies: | ||
| cupertino_ui: ^1.0.0 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| flutter_test: | ||
| sdk: flutter | ||
| mockito: ^5.0.0 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ | |
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| import 'package:flutter/cupertino.dart'; | ||
| import 'package:cupertino_ui/cupertino_ui.dart'; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| import 'package:flutter_test/flutter_test.dart'; | ||
| import 'package:google_fonts/src/google_fonts_family_with_variant.dart'; | ||
| import 'package:google_fonts/src/google_fonts_variant.dart'; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replacing the standard Flutter SDK import
package:flutter/material.dartwithpackage:material_ui/material_ui.dartis a critical error.google_fontsmust use the official Flutter SDK's material library to ensure that types likeTextStyleandTextThemeare fully compatible with standard Flutter widgets. Please revert this import back topackage:flutter/material.dart.