Skip to content

[material_ui] Animated theme test from flutter/flutter - #12487

Open
justinmc wants to merge 2 commits into
flutter:mainfrom
justinmc:material-animated-theme-test
Open

[material_ui] Animated theme test from flutter/flutter#12487
justinmc wants to merge 2 commits into
flutter:mainfrom
justinmc:material-animated-theme-test

Conversation

@justinmc

Copy link
Copy Markdown
Contributor

This test was created from Widgets tests in
flutter/flutter#186673 after the code was copied to flutter/packages, so it was missing from flutter/packages. This PR ports it over.

This test was created from Widgets tests in
flutter/flutter#186673, but the change never
made it over to flutter/packages.
@justinmc
justinmc requested review from Piinks and victorsanni August 17, 2026 20:06
@justinmc justinmc self-assigned this Aug 17, 2026
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Aug 17, 2026
@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: material_ui labels Aug 17, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new test file, animated_theme_test.dart, which verifies that the onEnd callback of the AnimatedTheme widget is triggered correctly when the theme animation completes. I have no review comments or feedback to provide.

@justinmc justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 17, 2026

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 17, 2026
@auto-submit

auto-submit Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/12487, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@justinmc justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 17, 2026
@auto-submit

auto-submit Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/12487, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 17, 2026
@Piinks Piinks added triage-design Should be looked at in design triage and removed triage-framework Should be looked at in framework triage labels Aug 17, 2026
@justinmc justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 18, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 18, 2026
@auto-submit

auto-submit Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/12487, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD p: material_ui triage-design Should be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants