[tool] Switch custom analysis allowance to local config#12088
[tool] Switch custom analysis allowance to local config#12088stuartmorgan-g wants to merge 3 commits into
Conversation
github-actions
Bot
added
p: web_benchmarks
p: rfw
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request deprecates the --custom-analysis command-line argument in the analyze tool in favor of a package-level configuration. It introduces the allow_custom_analysis_options property in ci_config.yaml files, allowing individual packages to opt-in to custom analysis options. The global custom analysis configuration file has been removed, and the analyze scripts, tool implementation, and tests have been updated accordingly. I have no feedback to provide.
| // TODO(stuartmorgan): Remove this entirely once the flutter/flutter and dart-lang repo scripts | ||
| // that run flutter/packages analysis have been updated not to pass it. |
There was a problem hiding this comment.
Is there an issue for this?
There was a problem hiding this comment.
No, but it's a simple change I'll do once this lands.
stuartmorgan-g
added
the
autosubmit
|
autosubmit label was removed for flutter/packages/12088, because - The status or check suite Windows_x64 repo_tools_tests has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
Bot
removed
the
autosubmit
2 participants
Switches from a global allow-list for custom analysis options to the new package-local config system. This eliminates the need for a global file change to adjust the setting for a single package, which makes CI much faster for such changes, without eliminating the desired feature of requiring devs to explicitly opt in to using a custom analysis options file (vs. adding one accidentally, or adding one without realizing there's a general policy against doing so).
The legacy flag is preserved, but ignored, so as not to break the flutter/flutter and dart-lang/sdk scripts that run analysis on our repo (to pre-detect issue that would block the roller). Once this lands I can update those scripts, then remove the flag.