[pigeon] make swift enum CaseIterable#11702
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request updates Pigeon to version 26.3.5 and adds CaseIterable conformance to generated Swift enums. Feedback indicates that the change lacks necessary tests or golden file updates to verify the generated code, as required by the style guide.
| ); | ||
|
|
||
| indent.write('enum ${anEnum.name}: Int '); | ||
| indent.write('enum ${anEnum.name}: Int, CaseIterable '); |
There was a problem hiding this comment.
The addition of CaseIterable to generated Swift enums is a useful improvement. However, I noticed that no new tests or updates to existing golden files were included in this pull request to verify this change. Please ensure that the generated output is covered by tests to prevent regressions and verify the correct syntax is produced.
instead of generating
we will now generate
allowing consumers to use
FooEnum.allCasesto iterate over all possible enum values in swift platform codefixes flutter/flutter#186447
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2