-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[google_sign_in_android] Update android libraries #11694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -287,7 +287,7 @@ public void onResult(GetCredentialResponse response) { | |
| googleIdTokenCredential.getDisplayName(), | ||
| googleIdTokenCredential.getFamilyName(), | ||
| googleIdTokenCredential.getGivenName(), | ||
| googleIdTokenCredential.getId(), | ||
| googleIdTokenCredential.getEmail(), | ||
| googleIdTokenCredential.getIdToken(), | ||
| profilePictureUri == null ? null : profilePictureUri.toString()))); | ||
| } else { | ||
|
|
@@ -384,7 +384,9 @@ public void authorize( | |
| } | ||
| if (params.getServerClientIdForForcedRefreshToken() != null) { | ||
| authorizationRequestBuilder.requestOfflineAccess( | ||
| params.getServerClientIdForForcedRefreshToken(), true); | ||
| params.getServerClientIdForForcedRefreshToken()); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For future me if I need to look at this pr. This pr is doing exactly what the documentation suggests. https://developers.google.com/android/reference/com/google/android/gms/auth/api/identity/AuthorizationRequest.Builder#requestOfflineAccess(java.lang.String,%20boolean) |
||
| // This requests a new refresh token | ||
| authorizationRequestBuilder.setPrompt(AuthorizationRequest.Prompt.CONSENT); | ||
| } | ||
| if (params.getAccountEmail() != null) { | ||
| authorizationRequestBuilder.setAccount( | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the dependency bumps are listed, the logic change in
GoogleSignInPlugin.java(migrating tosetPromptfor forced refresh tokens) should also be mentioned in the CHANGELOG to inform users of the implementation update, even if the intended behavior remains the same.