Skip to content

[pigeon] Adds support for analyzer 10#11346

Merged
auto-submit[bot] merged 5 commits intoflutter:mainfrom
tarrinneal:ana-10
Mar 26, 2026
Merged

[pigeon] Adds support for analyzer 10#11346
auto-submit[bot] merged 5 commits intoflutter:mainfrom
tarrinneal:ana-10

Conversation

@tarrinneal
Copy link
Contributor

@tarrinneal tarrinneal commented Mar 25, 2026

minimal required changes

fixes flutter/flutter#183568

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@tarrinneal tarrinneal added the CICD Run CI/CD label Mar 25, 2026
@github-actions github-actions bot added p: pigeon and removed CICD Run CI/CD labels Mar 25, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pigeon package version to 26.2.4 and extends the supported range for the analyzer dependency to include versions up to <11.0.0. The CHANGELOG.md and generator_tools.dart files are updated to reflect this version bump. The reviewer noted that the pull request description should be updated to include the Pre-Review Checklist as required by the repository's style guide.

@tarrinneal tarrinneal added CICD Run CI/CD and removed CICD Run CI/CD labels Mar 26, 2026
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit

@tarrinneal tarrinneal added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App and removed CICD Run CI/CD labels Mar 26, 2026
@auto-submit auto-submit bot merged commit e627503 into flutter:main Mar 26, 2026
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: pigeon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[pigeon] Support Analyzer ^10.0.0

2 participants