Skip to content

[camera_avfoundation] Remove unused Objective-C testing files#11240

Open
cdeil wants to merge 1 commit intoflutter:mainfrom
cdeil:rm-old-camera-avfoundation-objc-files
Open

[camera_avfoundation] Remove unused Objective-C testing files#11240
cdeil wants to merge 1 commit intoflutter:mainfrom
cdeil:rm-old-camera-avfoundation-objc-files

Conversation

@cdeil
Copy link

@cdeil cdeil commented Mar 13, 2026

Cleanup for flutter/flutter#119109 removing old unused files.

I ran into Pod-related error with the tests and saw that #11237 will resolve that, so this is just a draft that should wait for #11237 to land.

Pre-Review Checklist

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes unused Objective-C testing files (ExceptionCatcher.h, ExceptionCatcher.m, and RunnerTests-Bridging-Header.h) from the camera_avfoundation example. As part of this cleanup, references to these files are removed from the Xcode project file (project.pbxproj). Additionally, import Foundation statements are added to three Swift mock files that required it after the removal of the bridging header.

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added CICD Run CI/CD triage-ios Should be looked at in iOS triage labels Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD p: camera platform-ios platform-macos triage-ios Should be looked at in iOS triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants