Skip to content

[camera] Remove outdated TODO in camera_controller.dart#11239

Open
cdeil wants to merge 3 commits intoflutter:mainfrom
cdeil:rm-outdated-todo-camera-controller
Open

[camera] Remove outdated TODO in camera_controller.dart#11239
cdeil wants to merge 3 commits intoflutter:mainfrom
cdeil:rm-outdated-todo-camera-controller

Conversation

@cdeil
Copy link

@cdeil cdeil commented Mar 12, 2026

@stuartmorgan-g - this PR is a small cleanup that resolves an old TODO comment referencing Dart 2.
The camera package now requires Dart 3.9 so unawaited can be used.

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@cdeil cdeil requested a review from bparrishMines as a code owner March 12, 2026 18:49
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes a local _unawaited helper function and its associated TODO comment in packages/camera/camera/lib/src/camera_controller.dart. All usages of _unawaited have been replaced with the unawaited function from dart:async.

@cdeil cdeil requested a review from camsim99 as a code owner March 12, 2026 18:57
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added the CICD Run CI/CD label Mar 13, 2026
@stuartmorgan-g stuartmorgan-g added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes and removed CICD Run CI/CD labels Mar 13, 2026
@stuartmorgan-g stuartmorgan-g added the CICD Run CI/CD label Mar 13, 2026
@stuartmorgan-g
Copy link
Collaborator

Version/changelog override: while this technically changes production code, it is a very straightforward no-op.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: camera

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants