Skip to content

[camera_avfoundation] Remove outdated TODO comment in messages.dart#11236

Open
cdeil wants to merge 1 commit intoflutter:mainfrom
cdeil:rm-outdated-todo-in-camera-avfoundation-messages
Open

[camera_avfoundation] Remove outdated TODO comment in messages.dart#11236
cdeil wants to merge 1 commit intoflutter:mainfrom
cdeil:rm-outdated-todo-in-camera-avfoundation-messages

Conversation

@cdeil
Copy link

@cdeil cdeil commented Mar 12, 2026

The PR removes an outdated TODO code comment in the Pigeon messages.dart in camera_avfoundation.

@stuartmorgan-g - You already addressed it in 2024 here: 3584ddb#diff-ce4d13732a822cf36d7a1c574215e7974670567cd5667e2a1665c88ac5dc2615R163

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes a TODO comment from the CameraApi definition in packages/camera/camera_avfoundation/pigeons/messages.dart. The removed comment indicated a need to make a generic type non-nullable.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes an outdated TODO comment from the CameraApi class in packages/camera/camera_avfoundation/pigeons/messages.dart. This is a code cleanup and has no functional impact.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes a TODO comment from the CameraApi class in packages/camera/camera_avfoundation/pigeons/messages.dart. The removed comment was related to making a generic type non-nullable.

@stuartmorgan-g stuartmorgan-g added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes CICD Run CI/CD labels Mar 12, 2026
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks, I thought I had done a final sweep of the entire repo for this issue number to make sure I caught everything.

@stuartmorgan-g stuartmorgan-g requested review from bparrishMines and tarrinneal and removed request for tarrinneal March 12, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: camera platform-ios platform-macos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants