[pigeon] Reduces lint rules ignored in generated Dart code#11230
Open
srawlins wants to merge 1 commit intoflutter:mainfrom
Open
[pigeon] Reduces lint rules ignored in generated Dart code#11230srawlins wants to merge 1 commit intoflutter:mainfrom
srawlins wants to merge 1 commit intoflutter:mainfrom
Conversation
tarrinneal
approved these changes
Mar 11, 2026
Contributor
tarrinneal
left a comment
There was a problem hiding this comment.
If it's good enough for the linter, it's good enough for me @stuartmorgan-g for exceptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I landed #11149, which changes the
ignore_for_fileto usetype=lint, I didn't examine the list of lint rules we used to violate. In particular, since #11114 and #11163 landed, our generated code no longer violates the following rules:I believe this does not need CHANGELOG notes because users should not be using the hidden 'ignore-lints' flag. This list of individually ignored lint rules should only appear in our tests or our checked-in generated Dart files.
Pre-Review Checklist
[shared_preferences]///).