Skip to content

Fix deprecated kUTTypeGIF usage on iOS 15+ #10896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
varada2906 wants to merge 2 commits into from
Closed

Fix deprecated kUTTypeGIF usage on iOS 15+ #10896

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96fa174
Fix deprecated kUTTypeGIF usage on iOS 15+
varada2906 Jan 26, 2026
1652e66
Use UTTypeGIF.identifier from iOS 14
varada2906 Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .../image_picker_ios/ios/image_picker_ios/Sources/image_picker_ios/FLTImagePickerImageUtil.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

#import "FLTImagePickerImageUtil.h"
#import <MobileCoreServices/MobileCoreServices.h>
#import <UniformTypeIdentifiers/UniformTypeIdentifiers.h>


@interface GIFInfo ()

Expand Down Expand Up @@ -117,7 +119,14 @@ + (GIFInfo *)scaledGIFImage:(NSData *)data
maxHeight:(NSNumber *)maxHeight {
NSMutableDictionary<NSString *, id> *options = [NSMutableDictionary dictionary];
options[(NSString *)kCGImageSourceShouldCache] = @YES;
options[(NSString *)kCGImageSourceTypeIdentifierHint] = (NSString *)kUTTypeGIF;
if (@available(iOS 15.0, *)) {
options[(NSString *)kCGImageSourceTypeIdentifierHint] =
(NSString *)UTTypeGIF.identifier;
} else {
options[(NSString *)kCGImageSourceTypeIdentifierHint] =
(NSString *)kUTTypeGIF;
}

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this correctly fixes the deprecation warning on iOS 15, the UniformTypeIdentifiers API is available starting from iOS 14. It's better to adopt the new API from iOS 14 onwards. Also, the cast (NSString *) on UTTypeGIF.identifier is redundant as it already returns an NSString *. Finally, the indentation in this block is inconsistent and an extra blank line has been added, both of which should be fixed to improve readability.

  if (@available(iOS 14.0, *)) {
    options[(NSString *)kCGImageSourceTypeIdentifierHint] = UTTypeGIF.identifier;
  } else {
    options[(NSString *)kCGImageSourceTypeIdentifierHint] = (NSString *)kUTTypeGIF;
  }
References
  1. Code should follow the relevant style guides and use the correct auto-formatter for each language. The indentation in the added code block is inconsistent and an extra blank line was added. (link)


CGImageSourceRef imageSource =
CGImageSourceCreateWithData((__bridge CFDataRef)data, (__bridge CFDictionaryRef)options);
Expand Down