[camera_android_camerax] Improve error messages when image capture fails #10846
Conversation
Updated build_runner dependency version in dev_dependencies.
Adds detailed error messages for image capture failures.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request improves error handling in camera_android_camerax by providing more descriptive error messages when an image capture fails. The changes introduce a mechanism to send these detailed errors back to the developer via the onCameraError callback stream. This is accomplished by passing the SystemServicesManager to the takePicture method, which is then used within the onError callback to report specific error descriptions based on the ImageCaptureException code. The implementation includes a new helper method to map error codes to human-readable messages. All related tests have been updated to cover this new functionality. The changes are logical and well-implemented. I have one minor suggestion to improve code clarity in the new error handling logic.
...a_android_camerax/android/src/main/java/io/flutter/plugins/camerax/ImageCaptureProxyApi.java
Outdated
Show resolved
Hide resolved
…o/flutter/plugins/camerax/ImageCaptureProxyApi.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
| any(ImageCapture.OutputFileOptions.class), | ||
| any(Executor.class), | ||
| any(ImageCapture.OnImageSavedCallback.class)); | ||
| verify(mockSystemServicesManager).onCameraError(anyString()); |
There was a problem hiding this comment.
Can you update these test cases to make sure that at least one of the new error message is coming though end to end?
reidbaker
left a comment
reidbaker
left a comment
There was a problem hiding this comment.
Approve % some tests that verify that your new code is called and returns the expected new errors.
…s' into camx_throwMoreErrors
camsim99
added
the
autosubmit
flutter/packages@1cb2148...cd4fd61 2026-01-28 magder@google.com [quick_actions_ios] Migrate XCTest to Swift Testing (flutter/packages#10767) 2026-01-28 43054281+camsim99@users.noreply.github.com [camera_android_camerax] Improve documentation on `cameraId` parameter (flutter/packages#10844) 2026-01-28 43054281+camsim99@users.noreply.github.com [camera_android_camerax] Improve error messages when image capture fails (flutter/packages#10846) 2026-01-28 j.calvin.ren@gmail.com [image_picker] Transparent pressing on iOS 26 (#173453) (flutter/packages#10533) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
Sends camera errors back to the developer via the
onCameraErrorcallback stream when the camera fails to take a picture to help developers better handle encountering issues while the user is taking a picture.Fixes flutter/flutter#153091.
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3