Skip to content

Update publishing.md.#963

Open
polina-c wants to merge 3 commits into
flutter:mainfrom
polina-c:on-call
Open

Update publishing.md.#963
polina-c wants to merge 3 commits into
flutter:mainfrom
polina-c:on-call

Conversation

@polina-c

Copy link
Copy Markdown
Collaborator

Add instructions for on-call.

@polina-c polina-c requested a review from ditman June 10, 2026 00:11

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new "On-call responsibilities" section to the publishing documentation, outlining weekly tasks for releasing packages and handling 'wip' versions in the changelog. The reviewer suggested improving the Markdown formatting by replacing curly quotes with standard backticks, correcting typos, and fixing minor grammatical issues.

Note: Security Review has been skipped due to the limited scope of the PR.

Comment thread docs/contributing/publishing.md Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

@ditman ditman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having an explicit "-wip" choice makes this process a little bit more complicated; but I guess that's the Dart standard so let's go!


2.3. Comment on the PR that merged publishable changes under `wip`:

> This PR wrongly placed publishable changes under a `wip` version. This is corrected in PR <link>. See guidelines [here](https://github.com/flutter/genui/blob/main/docs/contributing/publishing.md#-wip-vs-non--wip-production-ready-versions).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needing this makes me feel that there's a point in the process that introduces ambiguity when reviewing. Do you think the "-wip" should be just a "escape hatch" when a change really really does not need to be published, that the reviewers can suggest to do?

For example, in flutter/packages, there's the same expectation of "auto-publish after every push", but what this flow calls "-wip" is called "NEXT" there (see this). NEXT changes are not expected to be published at all (and the automation skips them), and only when a real release happens, their changelog entries get merged into that of the release.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting.

I like the direction.

For me "NEXT" also means some changes.

I like 'noop' more.

And, 'wip' versions still may exist as development artifact, needed for testing.

I will review the doc from this perspective.

@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown

Package publishing

Package Version Status Publish tag (post-merge)
package:a2ui_core 0.0.1-wip002 ready to publish a2ui_core-v0.0.1-wip002
package:genai_primitives 0.2.4 ready to publish genai_primitives-v0.2.4
package:genui 0.9.2 already published at pub.dev
package:genui_a2a 0.9.0 already published at pub.dev
package:json_schema_builder 0.1.5 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants