Update publishing.md.#963
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds a new "On-call responsibilities" section to the publishing documentation, outlining weekly tasks for releasing packages and handling 'wip' versions in the changelog. The reviewer suggested improving the Markdown formatting by replacing curly quotes with standard backticks, correcting typos, and fixing minor grammatical issues.
Note: Security Review has been skipped due to the limited scope of the PR.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
ditman
left a comment
There was a problem hiding this comment.
I think having an explicit "-wip" choice makes this process a little bit more complicated; but I guess that's the Dart standard so let's go!
|
|
||
| 2.3. Comment on the PR that merged publishable changes under `wip`: | ||
|
|
||
| > This PR wrongly placed publishable changes under a `wip` version. This is corrected in PR <link>. See guidelines [here](https://github.com/flutter/genui/blob/main/docs/contributing/publishing.md#-wip-vs-non--wip-production-ready-versions). |
There was a problem hiding this comment.
Needing this makes me feel that there's a point in the process that introduces ambiguity when reviewing. Do you think the "-wip" should be just a "escape hatch" when a change really really does not need to be published, that the reviewers can suggest to do?
For example, in flutter/packages, there's the same expectation of "auto-publish after every push", but what this flow calls "-wip" is called "NEXT" there (see this). NEXT changes are not expected to be published at all (and the automation skips them), and only when a real release happens, their changelog entries get merged into that of the release.
There was a problem hiding this comment.
Interesting.
I like the direction.
For me "NEXT" also means some changes.
I like 'noop' more.
And, 'wip' versions still may exist as development artifact, needed for testing.
I will review the doc from this perspective.
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
Add instructions for on-call.