Conversation
…on fields, refactoring `configuration_reference.md` to link to it and updating `index.md` and `custom.css`.
| - `Job.sampleFilters` / `Job.sample_filters` — select samples by metadata tags | ||
| - `variant_filters` on task YAML — restrict which variants apply to a task (supplements `allowed_variants`) | ||
|
|
||
| - **`JobTask.args`.** Per-task argument overrides. Allows a job to pass task-specific arguments (e.g. `base_url`, `dataset_path`) to individual tasks. |
There was a problem hiding this comment.
This refers to job.yaml tasks.<task>.args JobTask is the underlying model
|
|
||
| - **`Job.description`.** Optional human-readable description field on Job. | ||
|
|
||
| - **`Job.imagePrefix` / `Job.image_prefix`.** Registry URL prefix prepended to image names during sandbox resolution. Enables switching between local images and remote registries (e.g. Artifact Registry on GKE) without duplicating job YAML files. |
There was a problem hiding this comment.
The imagePrefix/image_prefix thing is because Dart and Python changes are needed.
…resolvers and support colon syntax for task function resolution.
…, and expanded sandbox configuration options in documentation and API.
…rguments to resolved task metadata, updating the config parity tool.
…ration, and refine tag filtering logic.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the configuration system to improve its adaptability and extensibility, particularly for Yardstick and diverse local use cases. It introduces new configuration options, standardizes naming conventions, and decouples environment-specific settings, allowing for more flexible and maintainable evaluation setups. A major enhancement is the introduction of tag-based filtering, which provides powerful new ways to manage task and sample selection. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a significant number of updates to the configuration system to support Yardstick and local use cases. Key changes include adding new fields to Job and Task models (like description, imagePrefix, args), introducing tag-based filtering for tasks and samples, and making the sandbox registry configurable. The Task.taskFunc field has been consistently renamed to Task.func across the codebase. Extensive documentation has been added or updated to reflect these changes, including a new detailed YAML configuration reference.
My review focuses on ensuring consistency across the implementation and documentation. I've found a couple of minor inconsistencies in the documentation regarding field names. I also noticed one part of the implementation in the Dart resolver that seems to contradict the implementation plan regarding hardcoded setup commands. Overall, this is a well-structured and comprehensive update.
| if (workspace != null && isContainer) { | ||
| files = {...?files, '/workspace': workspace}; | ||
| setup = setup ?? 'cd /workspace && flutter pub get'; | ||
| setup ??= 'cd /workspace && flutter pub get'; | ||
| enriched['workspace'] = '/workspace'; | ||
| } |
There was a problem hiding this comment.
According to the implementation plan, the hardcoded flutter pub get command for workspace setup should be removed to make the configuration more generic and not assume a Flutter project. However, it's still present here. To align with the goal of making the system more project-agnostic, this line should be removed. The task author should explicitly specify the setup command in their task or sample YAML if one is needed.
if (workspace != null && isContainer) {
files = {...?files, '/workspace': workspace};
enriched['workspace'] = '/workspace';
}| `.flutter_channel` | ||
| - string | ||
| - Y | ||
| - | ||
| - | ||
| - Flutter SDK channel (`stable`, `beta`, `main`) |
There was a problem hiding this comment.
The field flutter_channel has been renamed to branch to be more generic, but this documentation still refers to the old name. Please update the field name and its description to reflect this change.
| `.flutter_channel` | |
| - string | |
| - Y | |
| - | |
| - | |
| - Flutter SDK channel (`stable`, `beta`, `main`) | |
| * - `variants`\ | |
| `.<name>`\ | |
| `.branch` | |
| - string | |
| - Y | |
| - | |
| - | |
| - SDK branch/channel to use (`stable`, `beta`, `main`) |
| | `context_files` | list | `[]` | Paths or glob patterns to context files (relative to task dir) | | ||
| | `skills` | list | `[]` | Paths or glob patterns to skill directories (relative to task dir) | | ||
| | `mcp_servers` | list | `[]` | MCP server identifiers | | ||
| Variant sub-fields (`context_files`, `mcp_servers`, `skills`, `flutter_channel`) are documented in the [Job fields table](yaml_config.md#job). |
There was a problem hiding this comment.
The documentation for variant sub-fields mentions flutter_channel, but this field has been renamed to branch to be more generic. Please update this reference to maintain consistency with the implementation.
| Variant sub-fields (`context_files`, `mcp_servers`, `skills`, `flutter_channel`) are documented in the [Job fields table](yaml_config.md#job). | |
| Variant sub-fields (`context_files`, `mcp_servers`, `skills`, `branch`) are documented in the [Job fields table](yaml_config.md#job). |
1 participant
Updating config to serve both our local use cases and Yardstick.