Add retry to eval_integration_test.dart to help with flake.#9825
Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom May 8, 2026
Merged
Add retry to eval_integration_test.dart to help with flake.#9825auto-submit[bot] merged 2 commits intoflutter:masterfrom
auto-submit[bot] merged 2 commits intoflutter:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates three integration tests in eval_integration_test.dart by updating the issue reference for a known flake and adding a retry mechanism. Feedback was provided to consolidate the duplicated test metadata (timeout, tags, retry, and TODO comments) into the parent group definition to adhere to the DRY principle and simplify future maintenance.
srawlins
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Band aid for #9484