Skip to content

Add retry to eval_integration_test.dart to help with flake.#9825

Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom
kenzieschmoll:evalflake
May 8, 2026
Merged

Add retry to eval_integration_test.dart to help with flake.#9825
auto-submit[bot] merged 2 commits intoflutter:masterfrom
kenzieschmoll:evalflake

Conversation

@kenzieschmoll
Copy link
Copy Markdown
Member

Band aid for #9484

@kenzieschmoll kenzieschmoll requested a review from a team as a code owner May 7, 2026 22:59
@kenzieschmoll kenzieschmoll requested review from srawlins and removed request for a team May 7, 2026 22:59
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates three integration tests in eval_integration_test.dart by updating the issue reference for a known flake and adding a retry mechanism. Feedback was provided to consolidate the duplicated test metadata (timeout, tags, retry, and TODO comments) into the parent group definition to adhere to the DRY principle and simplify future maintenance.

Comment thread packages/devtools_app/test/shared/eval_integration_test.dart Outdated
@kenzieschmoll kenzieschmoll added the autosubmit Merge PR when tree becomes green via auto submit App label May 8, 2026
@auto-submit auto-submit Bot merged commit 55c61f4 into flutter:master May 8, 2026
88 of 90 checks passed
@kenzieschmoll kenzieschmoll deleted the evalflake branch May 8, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App release-notes-not-required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants