[keyboard_detection_tizen] Introduce keyboard_detection_tizen#1020
Open
JSUYA wants to merge 3 commits into
Open
[keyboard_detection_tizen] Introduce keyboard_detection_tizen#1020JSUYA wants to merge 3 commits into
JSUYA wants to merge 3 commits into
Conversation
A Tizen-specific Flutter plugin that detects software keyboard (input panel) visibility by listening to the embedder's 'tizen/internal/inputpanel' event channel. Mirrors the keyboard_detection package API (KeyboardState / KeyboardDetectionController / KeyboardDetection widget).
Member
Author
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the keyboard_detection_tizen plugin, which monitors software keyboard visibility and geometry on Tizen via a platform-specific event channel. The implementation includes a controller for state management, an example application, and integration tests. Feedback identifies a compilation error in the event handler's switch statement and logic issues where keyboard geometry is incorrectly reset upon hiding. Additionally, the review highlights a race condition in asynchronous callback execution and suggests more idiomatic, side-effect-free implementations for state-to-boolean conversions.
JSUYA
force-pushed
the
keyboard_detection_tizen
branch
from
a55f6e6 to
e5bd46f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Tizen-specific Flutter plugin that detects software keyboard (input panel) visibility by listening to the embedder's
'tizen/internal/inputpanel' event channel.
Mirrors the keyboard_detection package API (KeyboardState / KeyboardDetectionController / KeyboardDetection widget).