Skip to content

[video_player_avplay] Update the way to call the SetDisplay API #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gin7773 wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −3
Open

[video_player_avplay] Update the way to call the SetDisplay API #1018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5d2b65
Update the way to call the SetDisplay API
gin7773 May 8, 2026
ded7c5c
update version
gin7773 May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/video_player_avplay/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.8.10

* Update the way to call the `SetDisplay` API.

## 0.8.9

* [DASH] Fix seek freeze issue.
Expand Down
2 changes: 1 addition & 1 deletion packages/video_player_avplay/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ To use this package, add `video_player_avplay` as a dependency in your `pubspec.

```yaml
dependencies:
video_player_avplay: ^0.8.9
video_player_avplay: ^0.8.10
```
Then you can import `video_player_avplay` in your Dart code:
Expand Down
2 changes: 1 addition & 1 deletion packages/video_player_avplay/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: video_player_avplay
description: Flutter plugin for displaying inline video on Tizen TV devices.
homepage: https://github.com/flutter-tizen/plugins
repository: https://github.com/flutter-tizen/plugins/tree/master/packages/video_player_avplay
version: 0.8.9
version: 0.8.10

environment:
sdk: ">=3.1.0 <4.0.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/video_player_avplay/tizen/src/plus_player.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,7 @@ bool PlusPlayer::SetDisplay() {
return false;
}
bool ret = ::SetDisplay(player_, plusplayer::DisplayType::kOverlay,
resource_id, x, y, width, height);
resource_id, 0, 0, width, height);
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

By hardcoding 0, 0 in the SetDisplay call, the variables x and y (declared and assigned on lines 434-436) are now unused. To maintain code quality and adhere to the Google C++ Style Guide, please remove these unused variables and update the ecore_wl2_window_geometry_get call (e.g., by passing nullptr for the unused coordinates if the API supports it).

References
  1. C++ code should follow the Google C++ Style Guide, which encourages clean code and avoiding unused variables. (link)

if (!ret) {
LOG_ERROR("[PlusPlayer] Player fail to set display.");
return false;
Expand Down
Loading