Skip to content

Support vulkan pipeline cache#185

Draft
xiaowei-guan wants to merge 2 commits into
flutter-tizen:masterfrom
xiaowei-guan:pipeline_cache
Draft

Support vulkan pipeline cache#185
xiaowei-guan wants to merge 2 commits into
flutter-tizen:masterfrom
xiaowei-guan:pipeline_cache

Conversation

@xiaowei-guan

Copy link
Copy Markdown
Contributor

Fix #181

@xiaowei-guan
xiaowei-guan marked this pull request as draft July 15, 2026 07:24

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the Vulkan pipeline cache in the Tizen embedder by retrieving the application's cache path and passing it to the Vulkan renderer configuration. The review feedback points out that if the cache path is empty, cache_path_.c_str() returns an empty string instead of nullptr, which does not align with the engine's expectation of receiving NULL to disable the cache. It is recommended to conditionally assign nullptr when the cache path is empty.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread flutter/shell/platform/tizen/tizen_renderer_vulkan.cc Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Vulkan pipeline cache

1 participant