minor error in read_probes from readpostpro#74
Open
Renaud-Matthias wants to merge 3 commits intofluiddyn:masterfrom
Open
minor error in read_probes from readpostpro#74Renaud-Matthias wants to merge 3 commits intofluiddyn:masterfrom
Renaud-Matthias wants to merge 3 commits intofluiddyn:masterfrom
Conversation
… probes which coordinates were not returned by the read_probes function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The read_probes function was not counting the probes properly and not returning the coordinates of the last probe. In an OpenFOAM postprocessing file, the probes coordinates are written in the header after comments #. One line for each probe. One commented line was not counted.