feat(AFC): Adding AFC print dialog#1900
Open
jimmyjon711 wants to merge 5 commits into
Open
Conversation
…d-On Signed-off-by: Jim Madill <jcmadill1@gmail.com>
- Refactored code with the help from claude to clean up looking up spool data and added a common method into afc mixin to easily return all necessary information for lane to be used in the lane panel and AFC print dialog. Signed-off-by: Jim Madill <jcmadill1@gmail.com>
- Reverted weight check - Added new warning for notifying user that filament is not loaded into lane. Signed-off-by: Jim Madill <jcmadill1@gmail.com>
jimmyjon711
force-pushed
the
afc_print_dialog
branch
from
c8e76f8 to
f35d0ab
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an AFC “print start” dialog (ported from Mainsail) to guide lane/tool mapping and surface basic filament/lane warnings before starting a job, while also de-duplicating AFC lane/spool lookup logic via the AFC mixin.
Changes:
- Introduces new AFC print-start dialog components (dialog + per-tool row) and wires the dialog into the Jobs/FileSystem and main status flows.
- Centralizes AFC lane+spool derived data in
AfcMixin.getAfcLaneInfo()and refactors the lane card to use it. - Adds English i18n strings and a shared typing for the derived lane/spool info shape.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/typings/klipper.d.ts | Adds Klipper.AfcSpoolLaneInfo typing for derived lane/spool info used by UI. |
| src/mixins/afc.ts | Adds getAfcLaneInfo() helper and shouldShowAfcDialog() gating for when to open the dialog. |
| src/locales/en.yaml | Adds app.afc.PrintStartDialog.* translations for dialog UI and warnings. |
| src/components/widgets/status/PrinterStatusCard.vue | Embeds dialog and triggers it from reprint flow before starting a job. |
| src/components/widgets/filesystem/FileSystem.vue | Embeds dialog and triggers it from Jobs/FileSystem “Print” action. |
| src/components/widgets/afc/dialogs/AfcPrintStartDialogTool.vue | New per-tool row component (lane selection + warnings/tooltip). |
| src/components/widgets/afc/dialogs/AfcPrintStartDialog.vue | New dialog wrapper; fetches metadata on open if needed, then starts print. |
| src/components/widgets/afc/AfcCardUnitLaneBody.vue | Refactors spool/lane display logic to use the new mixin helper. |
…g is shown. Signed-off-by: Jim Madill <jcmadill1@gmail.com>
pedrolamas
reviewed
Jul 4, 2026
Signed-off-by: Jim Madill <jcmadill1@gmail.com>
pedrolamas
reviewed
Jul 5, 2026
| import FileNameDialog from './FileNameDialog.vue' | ||
| import FileSystemGoToFileDialog from './FileSystemGoToFileDialog.vue' | ||
| import FilePreviewDialog from './FilePreviewDialog.vue' | ||
| import AfcPrintStartDialog from '@/components/widgets/afc/dialogs/AfcPrintStartDialog.vue' |
Member
There was a problem hiding this comment.
The AfcPrintStartDialog needs to move to App.vue so we can use from anywhere in the app - just like we currently do with SpoolmanDialog!
| import StatusControls from './StatusControls.vue' | ||
| import StatusTab from './StatusTab.vue' | ||
| import ReprintTab from './ReprintTab.vue' | ||
| import AfcPrintStartDialog from '@/components/widgets/afc/dialogs/AfcPrintStartDialog.vue' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This was done with the help from claude and reviewed after.
AFC Print Dialog working from Jobs page:
fluidd_jobs_print_dialog.mp4
AFC Print Dialog from Main page:
fluidd_jobs_print_dialog.mp4
Signed-off-by: Jim Madill jcmadill1@gmail.com