feat: adds basic axis_twist_compensation support#1838
Merged
pedrolamas merged 2 commits intoMay 12, 2026
Merged
Conversation
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds basic UI/typing support for Klipper axis twist compensation calibration, including a Cartographer-specific command entry, so users can trigger these calibration routines from the Toolhead widget.
Changes:
- Add
axis_twist_compensationto Klipper settings typings (with a newAxisTwistCompensationSettingsinterface). - Introduce new wait keys for the axis twist compensation-related commands.
- Add Toolhead “tools” entries for
AXIS_TWIST_COMPENSATION_CALIBRATEandCARTOGRAPHER_AXIS_TWIST_COMPENSATION.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/typings/klipper.d.ts | Adds axis_twist_compensation config typing + settings interface. |
| src/globals.ts | Adds wait keys for the new calibration commands. |
| src/components/widgets/toolhead/ToolheadCard.vue | Exposes the new commands in the Toolhead tools list based on printer config. |
Comment on lines
+249
to
+253
| get printerSupportsCartographerAxisTwistCompensation (): boolean { | ||
| return ( | ||
| this.printerSettings.cartographer != null && | ||
| this.printerSettings.axis_twist_compensation != null | ||
| ) |
Contributor
There was a problem hiding this comment.
The [scanner] section is part of the old cartographer code and is deprecated and should be removed as noted here: https://docs.cartographer3d.com/cartographer-probe/installation-and-setup/software-configuration/klipper-setup
Member
Author
There was a problem hiding this comment.
Old cartographer scanner check removed in d973872.
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds basic support for
AXIS_TWIST_COMPENSATION_CALIBRATE(andCARTOGRAPHER_AXIS_TWIST_COMPENSATIONwhen Cartographer is used)Resolves #1836