This PR fixes issue #4380 where some files failed to preheating successfully when using distributed load with replication configuration. #5666

argon2r · 2026-02-09T10:31:45Z

Ⅰ. Describe what this PR does

This PR fixes issue #4380 where some files failed to preheating successfully when
using distributed load with replication configuration.

Ⅱ. Does this pull request fix one issue?

fixes #4380

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

No new tests needed - template fix verified through existing DataLoad integration tests.

Ⅳ. Describe how to verify it

 apiVersion: data.fluid.io/v1alpha1
 kind: DataLoad
 metadata:
     name: test-load
 spec:
     target:
         - path: /data
         replicas: 2

Ⅴ. Special notes for reviews

Applied uniformly across all 6 runtime types
Type conversion at template rendering time only
Using | int filter is standard Helm approach for pointer conversion

…rations Signed-off-by: argon2r <armansinghof@gmail.com>

fluid-e2e-bot · 2026-02-09T10:31:56Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zwwhdls for approval by writing /assign @zwwhdls in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

fluid-e2e-bot · 2026-02-09T10:32:05Z

Hi @argon2r. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gemini-code-assist · 2026-02-09T10:32:06Z

Summary of Changes

Hello @argon2r, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug where files failed to preheat successfully when using distributed load configurations with replication. The core of the problem stemmed from implicit type handling of the replication count within Helm templates. By introducing an explicit integer conversion filter (| int) to the .replicas value, this change guarantees that the replication count is always correctly interpreted, thereby resolving the preheating failures and ensuring robust distributed data loading.

Highlights

Bug Fix: Resolved issue [BUG]When fluid and alluxio configured the data set to be preheated, it was found that some files were not preheated successfully #4380, which caused preheating failures in distributed load scenarios when replication was configured.
Type Conversion: Implemented explicit type conversion for the .replicas value in Helm templates by adding the | int filter.
Broad Application: The fix has been applied consistently across cronjob.yaml and job.yaml templates for all six supported dataloader runtimes (Alluxio, GooseFS, Jindo, Jindocache, Jindofsx, JuiceFS).
Preheating Reliability: Ensures proper interpretation of replication counts during template rendering, thereby preventing preheating issues in distributed data loading.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

charts/fluid-dataloader/alluxio/templates/cronjob.yaml
- Added | int filter to .replicas for explicit type conversion.
charts/fluid-dataloader/alluxio/templates/job.yaml
- Added | int filter to .replicas for explicit type conversion.
charts/fluid-dataloader/goosefs/templates/cronjob.yaml
- Added | int filter to .replicas for explicit type conversion.
charts/fluid-dataloader/goosefs/templates/job.yaml
- Added | int filter to .replicas for explicit type conversion.
charts/fluid-dataloader/jindo/templates/cronjob.yaml
- Added | int filter to .replicas for explicit type conversion.
charts/fluid-dataloader/jindo/templates/job.yaml
- Added | int filter to .replicas for explicit type conversion.
charts/fluid-dataloader/jindocache/templates/cronjob.yaml
- Added | int filter to .replicas for explicit type conversion.
charts/fluid-dataloader/jindocache/templates/job.yaml
- Added | int filter to .replicas for explicit type conversion.
charts/fluid-dataloader/jindofsx/templates/cronjob.yaml
- Added | int filter to .replicas for explicit type conversion.
charts/fluid-dataloader/jindofsx/templates/job.yaml
- Added | int filter to .replicas for explicit type conversion.
charts/fluid-dataloader/juicefs/templates/cronjob.yaml
- Added | int filter to .replicas for explicit type conversion.
charts/fluid-dataloader/juicefs/templates/job.yaml
- Added | int filter to .replicas for explicit type conversion.

Activity

The pull request was opened by argon2r to address issue [BUG]When fluid and alluxio configured the data set to be preheated, it was found that some files were not preheated successfully #4380.
The author confirmed that no new tests are needed, as the template fix was verified using existing DataLoad integration tests.
Verification steps were provided, including a sample DataLoad YAML configuration to demonstrate the fix.
The author highlighted that the fix is uniformly applied across all six runtime types, involves type conversion at template rendering time, and uses the standard Helm | int filter for pointer conversion.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

sonarqubecloud · 2026-02-09T10:32:47Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

gemini-code-assist

Code Review

This pull request addresses issue #4380 by fixing a data preheating failure during distributed load with replication. The fix involves adding an | int filter to correctly cast the .replicas value to an integer in Helm templates. This change is applied consistently across 12 template files for 6 different runtime types, which is the correct approach. The fix is sound and directly resolves the reported issue. I've also included a suggestion to refactor the string construction logic for replica paths to use a more idiomatic and maintainable pattern, which could be applied across all modified files.

gemini-code-assist · 2026-02-09T10:34:13Z

charts/fluid-dataloader/alluxio/templates/cronjob.yaml

              {{- $pathReplicas := ""}}
              {{- range .Values.dataloader.targetPaths }}
-              {{- $pathReplicas = cat $pathReplicas ( default 1 .replicas ) ":"}}
+              {{- $pathReplicas = cat $pathReplicas (default 1 .replicas | int) ":"}}
              {{- end }}
              {{- $pathReplicas = $pathReplicas | nospace | trimSuffix ":"}}


While the current implementation is correct, building the $pathReplicas string via repeated concatenation inside a loop can be less efficient and harder to read, especially with a large number of paths. A more idiomatic approach in Helm templates is to build a list of values and then join them into a string. This avoids intermediate string manipulation and cleanup steps like nospace and trimSuffix, leading to cleaner and more maintainable code.

This suggestion can be applied to all other modified files in this PR as they follow the same pattern.

{{- $replicas := list -}} {{- range .Values.dataloader.targetPaths -}} {{- $replicas = append $replicas (default 1 .replicas | int) -}} {{- end -}} {{- $pathReplicas := $replicas | join ":" -}}

gemini-code-assist · 2026-02-09T10:34:13Z

charts/fluid-dataloader/alluxio/templates/job.yaml

          {{- $pathReplicas := ""}}
          {{- range .Values.dataloader.targetPaths }}
-          {{- $pathReplicas = cat $pathReplicas ( default 1 .replicas ) ":"}}
+          {{- $pathReplicas = cat $pathReplicas (default 1 .replicas | int) ":"}}
          {{- end }}
          {{- $pathReplicas = $pathReplicas | nospace | trimSuffix ":"}}


While the current implementation is correct, building the $pathReplicas string via repeated concatenation inside a loop can be less efficient and harder to read, especially with a large number of paths. A more idiomatic approach in Helm templates is to build a list of values and then join them into a string. This avoids intermediate string manipulation and cleanup steps like nospace and trimSuffix, leading to cleaner and more maintainable code.

This suggestion can be applied to all other modified files in this PR as they follow the same pattern.

{{- $replicas := list -}} {{- range .Values.dataloader.targetPaths -}} {{- $replicas = append $replicas (default 1 .replicas | int) -}} {{- end -}} {{- $pathReplicas := $replicas | join ":" -}}

gemini-code-assist · 2026-02-09T10:34:13Z

charts/fluid-dataloader/goosefs/templates/cronjob.yaml

              {{- $pathReplicas := ""}}
              {{- range .Values.dataloader.targetPaths }}
-              {{- $pathReplicas = cat $pathReplicas ( default 1 .replicas ) ":"}}
+              {{- $pathReplicas = cat $pathReplicas (default 1 .replicas | int) ":"}}
              {{- end }}
              {{- $pathReplicas = $pathReplicas | nospace | trimSuffix ":"}}


While the current implementation is correct, building the $pathReplicas string via repeated concatenation inside a loop can be less efficient and harder to read, especially with a large number of paths. A more idiomatic approach in Helm templates is to build a list of values and then join them into a string. This avoids intermediate string manipulation and cleanup steps like nospace and trimSuffix, leading to cleaner and more maintainable code.

This suggestion can be applied to all other modified files in this PR as they follow the same pattern.

{{- $replicas := list -}} {{- range .Values.dataloader.targetPaths -}} {{- $replicas = append $replicas (default 1 .replicas | int) -}} {{- end -}} {{- $pathReplicas := $replicas | join ":" -}}

gemini-code-assist · 2026-02-09T10:34:13Z

charts/fluid-dataloader/goosefs/templates/job.yaml

          {{- $pathReplicas := ""}}
          {{- range .Values.dataloader.targetPaths }}
-          {{- $pathReplicas = cat $pathReplicas ( default 1 .replicas ) ":"}}
+          {{- $pathReplicas = cat $pathReplicas (default 1 .replicas | int) ":"}}
          {{- end }}
          {{- $pathReplicas = $pathReplicas | nospace | trimSuffix ":"}}


While the current implementation is correct, building the $pathReplicas string via repeated concatenation inside a loop can be less efficient and harder to read, especially with a large number of paths. A more idiomatic approach in Helm templates is to build a list of values and then join them into a string. This avoids intermediate string manipulation and cleanup steps like nospace and trimSuffix, leading to cleaner and more maintainable code.

This suggestion can be applied to all other modified files in this PR as they follow the same pattern.

{{- $replicas := list -}} {{- range .Values.dataloader.targetPaths -}} {{- $replicas = append $replicas (default 1 .replicas | int) -}} {{- end -}} {{- $pathReplicas := $replicas | join ":" -}}

gemini-code-assist · 2026-02-09T10:34:13Z

charts/fluid-dataloader/jindo/templates/cronjob.yaml

              {{- $pathReplicas := ""}}
              {{- range .Values.dataloader.targetPaths }}
-              {{- $pathReplicas = cat $pathReplicas ( default 1 .replicas ) ":"}}
+              {{- $pathReplicas = cat $pathReplicas (default 1 .replicas | int) ":"}}
              {{- end }}
              {{- $pathReplicas = $pathReplicas | nospace | trimSuffix ":"}}


While the current implementation is correct, building the $pathReplicas string via repeated concatenation inside a loop can be less efficient and harder to read, especially with a large number of paths. A more idiomatic approach in Helm templates is to build a list of values and then join them into a string. This avoids intermediate string manipulation and cleanup steps like nospace and trimSuffix, leading to cleaner and more maintainable code.

This suggestion can be applied to all other modified files in this PR as they follow the same pattern.

{{- $replicas := list -}} {{- range .Values.dataloader.targetPaths -}} {{- $replicas = append $replicas (default 1 .replicas | int) -}} {{- end -}} {{- $pathReplicas := $replicas | join ":" -}}

gemini-code-assist · 2026-02-09T10:34:13Z

charts/fluid-dataloader/jindocache/templates/job.yaml

          {{- $pathReplicas := ""}}
          {{- range .Values.dataloader.targetPaths }}
-          {{- $pathReplicas = cat $pathReplicas ( default 1 .replicas ) ":"}}
+          {{- $pathReplicas = cat $pathReplicas (default 1 .replicas | int) ":"}}
          {{- end }}
          {{- $pathReplicas = $pathReplicas | nospace | trimSuffix ":"}}


While the current implementation is correct, building the $pathReplicas string via repeated concatenation inside a loop can be less efficient and harder to read, especially with a large number of paths. A more idiomatic approach in Helm templates is to build a list of values and then join them into a string. This avoids intermediate string manipulation and cleanup steps like nospace and trimSuffix, leading to cleaner and more maintainable code.

This suggestion can be applied to all other modified files in this PR as they follow the same pattern.

{{- $replicas := list -}} {{- range .Values.dataloader.targetPaths -}} {{- $replicas = append $replicas (default 1 .replicas | int) -}} {{- end -}} {{- $pathReplicas := $replicas | join ":" -}}

gemini-code-assist · 2026-02-09T10:34:13Z

charts/fluid-dataloader/jindofsx/templates/cronjob.yaml

              {{- $pathReplicas := ""}}
              {{- range .Values.dataloader.targetPaths }}
-              {{- $pathReplicas = cat $pathReplicas ( default 1 .replicas ) ":"}}
+              {{- $pathReplicas = cat $pathReplicas (default 1 .replicas | int) ":"}}
              {{- end }}
              {{- $pathReplicas = $pathReplicas | nospace | trimSuffix ":"}} 


While the current implementation is correct, building the $pathReplicas string via repeated concatenation inside a loop can be less efficient and harder to read, especially with a large number of paths. A more idiomatic approach in Helm templates is to build a list of values and then join them into a string. This avoids intermediate string manipulation and cleanup steps like nospace and trimSuffix, leading to cleaner and more maintainable code.

This suggestion can be applied to all other modified files in this PR as they follow the same pattern.

{{- $replicas := list -}} {{- range .Values.dataloader.targetPaths -}} {{- $replicas = append $replicas (default 1 .replicas | int) -}} {{- end -}} {{- $pathReplicas := $replicas | join ":" -}}

gemini-code-assist · 2026-02-09T10:34:13Z

charts/fluid-dataloader/jindofsx/templates/job.yaml

          {{- $pathReplicas := ""}}
          {{- range .Values.dataloader.targetPaths }}
-          {{- $pathReplicas = cat $pathReplicas ( default 1 .replicas ) ":"}}
+          {{- $pathReplicas = cat $pathReplicas (default 1 .replicas | int) ":"}}
          {{- end }}
          {{- $pathReplicas = $pathReplicas | nospace | trimSuffix ":"}}  


While the current implementation is correct, building the $pathReplicas string via repeated concatenation inside a loop can be less efficient and harder to read, especially with a large number of paths. A more idiomatic approach in Helm templates is to build a list of values and then join them into a string. This avoids intermediate string manipulation and cleanup steps like nospace and trimSuffix, leading to cleaner and more maintainable code.

This suggestion can be applied to all other modified files in this PR as they follow the same pattern.

{{- $replicas := list -}} {{- range .Values.dataloader.targetPaths -}} {{- $replicas = append $replicas (default 1 .replicas | int) -}} {{- end -}} {{- $pathReplicas := $replicas | join ":" -}}

gemini-code-assist · 2026-02-09T10:34:13Z

charts/fluid-dataloader/juicefs/templates/cronjob.yaml

              {{- $pathReplicas := ""}}
              {{- range .Values.dataloader.targetPaths }}
-              {{- $pathReplicas = cat $pathReplicas ( default 1 .replicas ) ":"}}
+              {{- $pathReplicas = cat $pathReplicas (default 1 .replicas | int) ":"}}
              {{- end }}
              {{- $pathReplicas = $pathReplicas | nospace | trimSuffix ":"}}


While the current implementation is correct, building the $pathReplicas string via repeated concatenation inside a loop can be less efficient and harder to read, especially with a large number of paths. A more idiomatic approach in Helm templates is to build a list of values and then join them into a string. This avoids intermediate string manipulation and cleanup steps like nospace and trimSuffix, leading to cleaner and more maintainable code.

This suggestion can be applied to all other modified files in this PR as they follow the same pattern.

{{- $replicas := list -}} {{- range .Values.dataloader.targetPaths -}} {{- $replicas = append $replicas (default 1 .replicas | int) -}} {{- end -}} {{- $pathReplicas := $replicas | join ":" -}}

gemini-code-assist · 2026-02-09T10:34:13Z

charts/fluid-dataloader/juicefs/templates/job.yaml

          {{- $pathReplicas := ""}}
          {{- range .Values.dataloader.targetPaths }}
-          {{- $pathReplicas = cat $pathReplicas ( default 1 .replicas ) ":"}}
+          {{- $pathReplicas = cat $pathReplicas (default 1 .replicas | int) ":"}}
          {{- end }}
          {{- $pathReplicas = $pathReplicas | nospace | trimSuffix ":"}}


While the current implementation is correct, building the $pathReplicas string via repeated concatenation inside a loop can be less efficient and harder to read, especially with a large number of paths. A more idiomatic approach in Helm templates is to build a list of values and then join them into a string. This avoids intermediate string manipulation and cleanup steps like nospace and trimSuffix, leading to cleaner and more maintainable code.

This suggestion can be applied to all other modified files in this PR as they follow the same pattern.

{{- $replicas := list -}} {{- range .Values.dataloader.targetPaths -}} {{- $replicas = append $replicas (default 1 .replicas | int) -}} {{- end -}} {{- $pathReplicas := $replicas | join ":" -}}

Fix: resolve partial file preheating failures in distributed load ope…

b930103

…rations Signed-off-by: argon2r <armansinghof@gmail.com>

fluid-e2e-bot bot added the needs-ok-to-test label Feb 9, 2026

gemini-code-assist bot reviewed Feb 9, 2026

View reviewed changes

This PR fixes issue #4380 where some files failed to preheating successfully when using distributed load with replication configuration. #5666

Are you sure you want to change the base?

This PR fixes issue #4380 where some files failed to preheating successfully when using distributed load with replication configuration. #5666

Conversation

argon2r commented Feb 9, 2026

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Uh oh!

fluid-e2e-bot bot commented Feb 9, 2026

Uh oh!

fluid-e2e-bot bot commented Feb 9, 2026

Uh oh!

gemini-code-assist bot commented Feb 9, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

sonarqubecloud bot commented Feb 9, 2026

Quality Gate passed

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant