Skip to content

test(Validation): Migrate validation_test.go to Ginkgo/Gomega #5647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yuvraj-kolkar17 wants to merge 3 commits into from
Closed

test(Validation): Migrate validation_test.go to Ginkgo/Gomega #5647

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c12df1a
Migrate validation_test.go to Ginkgo/Gomega
yuvraj-kolkar17 Jan 31, 2026
e2e7eae
Resolve
yuvraj-kolkar17 Jan 31, 2026
91060d2
CI Fix
yuvraj-kolkar17 Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions pkg/utils/validation/validation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,15 @@ import (
"k8s.io/apimachinery/pkg/util/validation"
)

const invalidMountRootErrMsgFmt string = "invalid mount root path '%s': %s"
// InvalidMountRootErrMsgFmt is the error message format for invalid mount root paths
const InvalidMountRootErrMsgFmt string = "invalid mount root path '%s': %s"

func IsValidMountRoot(path string) error {
if len(path) == 0 {
return fmt.Errorf(invalidMountRootErrMsgFmt, path, "the mount root path is empty")
return fmt.Errorf(InvalidMountRootErrMsgFmt, path, "the mount root path is empty")
}
if !filepath.IsAbs(path) {
return fmt.Errorf(invalidMountRootErrMsgFmt, path, "the mount root path must be an absolute path")
return fmt.Errorf(InvalidMountRootErrMsgFmt, path, "the mount root path must be an absolute path")
}
// Normalize the path and split it into components
// The path is an absolute path and to avoid an empty part, we omit the first '/'
Expand All @@ -45,7 +46,7 @@ func IsValidMountRoot(path string) error {
// If the component fails the DNS 1123 conformity test, the function returns an error
errs := validation.IsDNS1123Label(part)
if len(errs) > 0 {
return fmt.Errorf(invalidMountRootErrMsgFmt, path, "every directory name in the mount root path shuold follow the relaxed DNS (RFC 1123) rule which additionally allows upper case alphabetic character and character '_'")
return fmt.Errorf(InvalidMountRootErrMsgFmt, path, "every directory name in the mount root path shuold follow the relaxed DNS (RFC 1123) rule which additionally allows upper case alphabetic character and character '_'")
Comment thread
yuvraj-kolkar17 marked this conversation as resolved.
Outdated
}
}

Expand Down
145 changes: 62 additions & 83 deletions pkg/utils/validation/validation_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,99 +14,78 @@ See the License for the specific language governing permissions and
limitations under the License.
*/

package validation
package validation_test

import (
"fmt"
"path/filepath"
"strings"
"testing"
)

func FuzzIsSafePath(f *testing.F) {
// f.Add()
f.Fuzz(func(t *testing.T, input string) {
err := IsValidMountRoot(input)
if err == nil {
// valid input must start with "/"
if !strings.HasPrefix(input, string(filepath.Separator)) {
t.Errorf("testcase %s failed, expect the input starts with '/'", input)
}
}
})
}
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"

func TestIsSafePathWithSafePath(t *testing.T) {

type testCase struct {
name string
input string
}

testCases := []testCase{
{
name: "validPath-1",
input: "/runtime-mnt//alluxio/default/hbase",
},
{
name: "validPath-2",
input: "/opt/20-Runtime-Mnt_1/./alluxio/default/hbase",
},
}
"github.com/fluid-cloudnative/fluid/pkg/utils/validation"
)

for _, test := range testCases {
tt := filepath.Clean(test.input)
print(tt)
got := IsValidMountRoot(test.input)
if got != nil {
t.Errorf("testcase %s failed, expect no error happened, but got an error: %s", test.name, got.Error())
}
}
func TestValidation(t *testing.T) {
RegisterFailHandler(Fail)
RunSpecs(t, "Validation Suite")
}

func TestIsSafePathWithInvalidPath(t *testing.T) {
var _ = Describe("IsValidMountRoot", func() {
Context("with valid mount root paths", func() {
DescribeTable("should accept valid paths",
func(input string) {
err := validation.IsValidMountRoot(input)
Expect(err).To(BeNil())
},
Entry("validPath-1: path with double slashes", "/runtime-mnt//alluxio/default/hbase"),
Entry("validPath-2: path with numbers, underscores and dot", "/opt/20-Runtime-Mnt_1/./alluxio/default/hbase"),
)

type testCase struct {
name string
input string
expect error
}
It("should have paths that start with /", func() {
validPaths := []string{
"/runtime-mnt//alluxio/default/hbase",
"/opt/20-Runtime-Mnt_1/./alluxio/default/hbase",
}

for _, path := range validPaths {
err := validation.IsValidMountRoot(path)
if err == nil {
Expect(path).To(HavePrefix(string(filepath.Separator)))
}
}
})
})

testCases := []testCase{
{
name: "invalidPath-1",
input: "/$test/alluxio/default/hbase",
expect: fmt.Errorf(invalidMountRootErrMsgFmt, "/$test/alluxio/default/hbase", "every directory name in the mount root path shuold follow the relaxed DNS (RFC 1123) rule which additionally allows upper case alphabetic character and character '_'"),
},
{
name: "invalidPath-2",
input: "/test/(alluxio)/default/hbase",
expect: fmt.Errorf(invalidMountRootErrMsgFmt, "/test/(alluxio)/default/hbase", "every directory name in the mount root path shuold follow the relaxed DNS (RFC 1123) rule which additionally allows upper case alphabetic character and character '_'"),
},
{
name: "invalidPath-3",
input: "/test/alluxio/def;ault/hbase",
expect: fmt.Errorf(invalidMountRootErrMsgFmt, "/test/alluxio/def;ault/hbase", "every directory name in the mount root path shuold follow the relaxed DNS (RFC 1123) rule which additionally allows upper case alphabetic character and character '_'"),
},
{
name: "invalidPath-4",
input: "",
expect: fmt.Errorf(invalidMountRootErrMsgFmt, "", "the mount root path is empty"),
},
{
name: "invalidPath-5",
input: "runtime-mnt/default",
expect: fmt.Errorf(invalidMountRootErrMsgFmt, "runtime-mnt/default", "the mount root path must be an absolute path"),
},
}
Context("with invalid mount root paths", func() {
DescribeTable("should reject invalid paths",
func(input string, expectedErrorMsg string) {
err := validation.IsValidMountRoot(input)
Expect(err).To(HaveOccurred())
Expect(err.Error()).To(Equal(expectedErrorMsg))
},
Entry("invalidPath-1: path with $",
"/$test/alluxio/default/hbase",
fmt.Sprintf(validation.InvalidMountRootErrMsgFmt, "/$test/alluxio/default/hbase", "every directory name in the mount root path shuold follow the relaxed DNS (RFC 1123) rule which additionally allows upper case alphabetic character and character '_'"),
),
Entry("invalidPath-2: path with parentheses",
"/test/(alluxio)/default/hbase",
fmt.Sprintf(validation.InvalidMountRootErrMsgFmt, "/test/(alluxio)/default/hbase", "every directory name in the mount root path shuold follow the relaxed DNS (RFC 1123) rule which additionally allows upper case alphabetic character and character '_'"),
),
Entry("invalidPath-3: path with semicolon",
"/test/alluxio/def;ault/hbase",
fmt.Sprintf(validation.InvalidMountRootErrMsgFmt, "/test/alluxio/def;ault/hbase", "every directory name in the mount root path shuold follow the relaxed DNS (RFC 1123) rule which additionally allows upper case alphabetic character and character '_'"),
),
Entry("invalidPath-4: empty path",
"",
fmt.Sprintf(validation.InvalidMountRootErrMsgFmt, "", "the mount root path is empty"),
),
Entry("invalidPath-5: relative path",
"runtime-mnt/default",
fmt.Sprintf(validation.InvalidMountRootErrMsgFmt, "runtime-mnt/default", "the mount root path must be an absolute path"),
),
)
})

for _, test := range testCases {
got := IsValidMountRoot(test.input)
if got == nil {
t.Errorf("testcase %s failed, expect an error happened, but got no error", test.name)
}
if got.Error() != test.expect.Error() {
t.Errorf("testcase %s failed, expect error: %v, but got error: %v", test.name, test.expect, got)
}
}
}
})
Loading