refactor(efc): migrate worker_test.go to Ginkgo/Gomega #5501
Conversation
Signed-off-by: Harsh <harshmastic@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello @hxrshxz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the test infrastructure for the EFC package by migrating its worker-related tests from the standard Go testing library to the Ginkgo and Gomega frameworks. This change aims to enhance the clarity, expressiveness, and maintainability of the tests by adopting a BDD style, without introducing new test cases or altering the existing test coverage. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Hi @hxrshxz. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request successfully migrates the worker_test.go file from standard Go testing to the Ginkgo/Gomega framework, and introduces efc_suite_test.go for proper test discovery. This is a positive step towards a more structured and readable testing approach. However, there is significant code duplication in the test setup within several Describe blocks. Refactoring these common setup steps into BeforeEach blocks would greatly improve the maintainability and readability of the tests.
hxrshxz
force-pushed
the
refactor/ginkgo-efc-worker-test
branch
from
6849c05 to
55a0109
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5501 +/- ##
==========================================
+ Coverage 56.76% 61.29% +4.52%
==========================================
Files 443 444 +1
Lines 30735 30540 -195
==========================================
+ Hits 17447 18718 +1271
+ Misses 11734 10280 -1454
+ Partials 1554 1542 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -0,0 +1,29 @@ | |||
| /* | |||
| Copyright 2022 The Fluid Authors. | |||
Signed-off-by: Harsh <harshmastic@gmail.com>
hxrshxz
force-pushed
the
refactor/ginkgo-efc-worker-test
branch
from
55a0109 to
28dd82f
Compare
|
There was a problem hiding this comment.
Pull request overview
Refactors EFC worker unit tests to run under the Ginkgo/Gomega test framework as part of the broader effort to standardize testing across the repository (#5407).
Changes:
- Migrated
pkg/ddc/efc/worker_test.gofromtesting.Ttable tests to GinkgoDescribe/Context/Itstructure with Gomega assertions. - Added
pkg/ddc/efc/efc_suite_test.goto register the EFC Ginkgo test suite for discovery/execution. - Updated the copyright year in
pkg/ddc/goosefs/backup_data.go.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/ddc/goosefs/backup_data.go | Updates file header copyright year (unrelated to the stated test-migration goal). |
| pkg/ddc/efc/worker_test.go | Converts EFC worker tests to Ginkgo/Gomega structure and assertions. |
| pkg/ddc/efc/efc_suite_test.go | Adds a Ginkgo suite entrypoint (RunSpecs) for EFC package tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /* | ||
| Copyright 2022 The Fluid Authors. | ||
| Copyright 2026 The Fluid Authors. | ||
|
|
There was a problem hiding this comment.
This file’s header year was changed from 2022 to 2026, but the PR description is only about migrating EFC worker tests to Ginkgo/Gomega. Please either drop this unrelated change (keep the original year) or update the PR description to explain why this file’s copyright header is being modified.
| } | ||
| BeforeEach(func() { | ||
| var err error | ||
| runtimeInfo, err = base.BuildRuntimeInfo(workerTestNamespaceEFC, workerTestNamespaceFluid, common.EFCRuntime) |
There was a problem hiding this comment.
base.BuildRuntimeInfo takes (name, namespace, runtimeType), but here it’s being called with namespace constants as the name argument. This makes the helper’s runtimeInfo inconsistent with the EFCRuntime/Dataset objects created in the It blocks (e.g., name "test" in namespace "fluid"), and can cause SetupWorkers to fail unexpectedly if it ever needs to call helper logic that looks up the Dataset by runtimeInfo name/namespace. Consider building runtimeInfo using the runtime/dataset name under test (or make the test objects use the same name consistently).
| runtimeInfo, err = base.BuildRuntimeInfo(workerTestNamespaceEFC, workerTestNamespaceFluid, common.EFCRuntime) | |
| runtimeInfo, err = base.BuildRuntimeInfo("test", workerTestNamespaceFluid, common.EFCRuntime) |
2 participants
Ⅰ. Describe what this PR does
Refactor
pkg/ddc/efc/worker_test.gofrom standard Go testing to Ginkgo/Gomega framework. Also creates efc_suite_test.go for proper Ginkgo test discovery.Ⅱ. Does this pull request fix one issue?
part of #5407
Ⅲ. List the added test cases if any
No new test cases added - this is a refactoring of existing tests to Ginkgo/Gomega format while maintaining the same coverage.
Ⅳ. Describe how to verify it
Run:
go test ./pkg/ddc/efc/... -run TestEfc -vⅤ. Special notes for reviews