in_prometheus: do not disclosure error details for client - #259
Merged
Conversation
kenhys
changed the title
Watson1978
reviewed
Jul 31, 2026
Watson1978
approved these changes
Jul 31, 2026
kenhys
force-pushed
the
suppress-exception
branch
from
August 3, 2026 03:37
d52876d to
9bb53f1
Compare
It is reasonable to logging error, but no need to disclose detail for client. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys
force-pushed
the
suppress-exception
branch
from
August 3, 2026 03:38
9bb53f1 to
dfc7049
Compare
Watson1978
reviewed
Aug 4, 2026
Contributor
|
Can you add |
Watson1978
reviewed
Aug 4, 2026
kenhys
force-pushed
the
suppress-exception
branch
from
August 5, 2026 05:12
dfc7049 to
f25fe66
Compare
/metrics and /aggregated_metrics are assumed that these API will be called periodically. If internal server error occurs continuously, it means that same error log will be recorded. That is incompatible behavior before. To record detailed logs as often as necessary, introduced `ignore_error_log_interval`. Fluentd itself have ignore_repeated_log_interval and ignore_same_log_interval, but it must be system wide configuration. The scope of error handling should be limited to this plugin, so do not escalate system wide configuration. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys
force-pushed
the
suppress-exception
branch
from
August 5, 2026 05:15
f25fe66 to
3aa1547
Compare
Watson1978
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is reasonable to logging error, but no need to disclose detail for client.