Skip to content

out_azure_kusto: avoid logging workload identity token#12148

Open
admhn wants to merge 1 commit into
fluent:masterfrom
admhn:admhn/fix/azure-workload-identity-token-log
Open

out_azure_kusto: avoid logging workload identity token#12148
admhn wants to merge 1 commit into
fluent:masterfrom
admhn:admhn/fix/azure-workload-identity-token-log

Conversation

@admhn

@admhn admhn commented Jul 23, 2026

Copy link
Copy Markdown

Summary

  • Prevent the federated workload identity token from being included in an INFO log.

Fixes #12145


Testing

  • [N/A] Example configuration file for the change
  • [N/A] Debug log output from testing
  • [N/A] Attached Valgrind output that shows no leaks or memory corruption was found
  • ctest --test-dir build -R flb-rt-out_azure_kusto --output-on-failure (1/1 passed)
  • [N/A] Run local packaging test showing all targets (including any new ones) build.
  • [N/A] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [N/A] Documentation required for this feature

Backporting

  • [N/A] Backport to latest stable release.

Summary by CodeRabbit

  • Bug Fixes
    • Removed an unnecessary informational log message during Azure workload identity authentication.

@admhn
admhn requested review from cosmo0920 and edsiper as code owners July 23, 2026 16:53
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a10f3a4b-d14c-4e34-92c1-52273fe94b35

📥 Commits

Reviewing files that changed from the base of the PR and between 0cee842 and 257e2bd.

📒 Files selected for processing (1)
  • plugins/out_azure_kusto/azure_msiauth.c
💤 Files with no reviewable changes (1)
  • plugins/out_azure_kusto/azure_msiauth.c

📝 Walkthrough

Walkthrough

Azure workload identity token acquisition no longer logs the federated token after reading it. Request construction continues unchanged.

Changes

Azure workload identity logging

Layer / File(s) Summary
Redact sensitive authentication logs
plugins/out_azure_kusto/azure_msiauth.c
The informational log containing the federated token was removed, and execution proceeds to request-body construction.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: cosmo0920

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: removing workload identity token logging from out_azure_kusto.
Linked Issues check ✅ Passed The change removes the INFO log that exposed the federated token, matching #12145's requirement.
Out of Scope Changes check ✅ Passed The PR only touches the token logging path in azure_msiauth.c and stays within the issue scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@admhn
admhn marked this pull request as draft July 23, 2026 16:56
@admhn
admhn force-pushed the admhn/fix/azure-workload-identity-token-log branch from 0cee842 to 9aff739 Compare July 23, 2026 16:58
Signed-off-by: admhn <61081143+admhn@users.noreply.github.com>
@admhn
admhn force-pushed the admhn/fix/azure-workload-identity-token-log branch from 9aff739 to 257e2bd Compare July 23, 2026 17:01
@admhn
admhn marked this pull request as ready for review July 23, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

out_azure_kusto: avoid logging workload identity token at info level

1 participant