out_azure_blob: correctly handle successful Delete Blob responses#11925
out_azure_blob: correctly handle successful Delete Blob responses#11925Vaibhav-C-S wants to merge 1 commit into
Conversation
Signed-off-by: Vaibhav-C-S <vaibhavsharma.c@gmail.com>
📝 WalkthroughWalkthroughThe Azure Blob Storage output plugin's ChangesAzure Blob Delete Status Code
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
gentle ping @cosmo0920 @edsiper , can you please review this pr in your free time? It is a small and focused fix. |
Fixes an incorrect success status check in the Azure Blob output delete path.
Azure Blob Storage Delete Blob returns HTTP 202 Accepted on success, but delete_blob() was checking for HTTP 201 Created. This caused successful delete responses in the stale/aborted buffered-file cleanup path to be treated as failures.
Reference:
https://learn.microsoft.com/en-us/rest/api/storageservices/delete-blob
No issue.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
Tested locally with a mock Azure Blob endpoint returning HTTP
202forDELETErequests. Sincedelete_blob()is reached through the database-backed stale/aborted cleanup path, I inserted an aborted file row into the local Azure Blob buffering database to trigger that path.Before this change, Fluent Bit treated the
202response as a failure:After this change, Fluent Bit accepted the
202response as successful:This change only updates the expected HTTP success status code for Azure Blob delete responses. It does not add allocations or change memory ownership.
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.
Summary by CodeRabbit