out_loki: make it clear setting labels removes the keys from record#1536
out_loki: make it clear setting labels removes the keys from record#1536ajantti wants to merge 1 commit intofluent:masterfrom
Conversation
|
Thanks for the contribution but please resolve the DCO requirements - we cannot merge without it unfortunately. |
eschabell
added
waiting-for-user
|
@ajantti I've nudged the code PR fluent/fluent-bit#9766 for review to get that moved forward, once that is merged, this docs PR could merge if you could please fix the current conflicts? |
|
@esmerel another one to review and not merge please, just need the review! |
esmerel
removed
conflict
|
Sorry for taking a while. The conflict was in a minor typo fix, but I hope the thing I wrote about the labels is correct. It's just a clarification on how I think it's supposed to work, based on the pull request fluent/fluent-bit#9766 Although, as mentioned in the comments of the pull request, I think it might've been already accidentally fixed in master by fluent/fluent-bit#10563 (albeit with some inefficiencies) |
ajantti
force-pushed
the
master
branch
2 times, most recently
from
c116813 to
fc010c6
Compare
The documentation doesn't make it clear, but the code seems to be trying to work this way. Signed-off-by: jantti <jantti@tri-ace.co.jp>
5 participants
Related to the pull request fluent/fluent-bit#9766 The documentation doesn't make it clear, but the code seems to be trying to work this way.
Also minor typo fix.