CMake: prefer Python virtual environment if present#202
CMake: prefer Python virtual environment if present#202elgiano wants to merge 1 commit intoflucoma:mainfrom
Conversation
|
I don't know what @weefuzzy think of this, but personally I use virtual environments by declaring:
when I cmake the sc repo and boom, it works. |
|
I don't see a compelling reason to bake this preference into the cmake code. Things like To make it less annoying to set every time you could make a |
|
Hi @elgiano I hadn't forgotten about this :-) I'm starting to tidy things up for our CI. What I'm minded to do now is just have CMake take care of the whole python mess itself by making its own |
|
Yes!
…-------- Original Message --------
On 3/31/25 19:25, Owen Green wrote:
Hi ***@***.***(https://github.com/elgiano)
I hadn't forgotten about this :-) I'm starting to tidy things up for our CI. What I'm minded to do now is just have CMake take care of the whole python mess itself by making its own venv in the build folder and calling pip to install the python requirements. Would obviate the need for this PR for you?
—
Reply to this email directly, [view it on GitHub](#202 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AACNMWS7FCMGTMULWZVJ2J32XF27RAVCNFSM6AAAAABOG5MLSWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONRWHA4TIOJQG4).
You are receiving this because you were mentioned.Message ID: ***@***.***>
[weefuzzy]weefuzzy left a comment [(flucoma/flucoma-docs#202)](#202 (comment))
Hi ***@***.***(https://github.com/elgiano)
I hadn't forgotten about this :-) I'm starting to tidy things up for our CI. What I'm minded to do now is just have CMake take care of the whole python mess itself by making its own venv in the build folder and calling pip to install the python requirements. Would obviate the need for this PR for you?
—
Reply to this email directly, [view it on GitHub](#202 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AACNMWS7FCMGTMULWZVJ2J32XF27RAVCNFSM6AAAAABOG5MLSWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONRWHA4TIOJQG4).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@weefuzzy would there be a bypass methods like the other dependencies, to use local env for people who are download-averse ? |
When auto-detecting python for building docs, prefer a version from a virtual environment if present.
I come to this problem when building flucoma-sc. As I don't want to install flucoma-docs dependencies system-wise, I create a virtual environment in my build folder, and
pip installjust there. With this PR, the build system detects the virtual env automatically.