fix(flow-php/symfony-telemetry-bundle): run DBALTelemetryPass before DoctrineBundle's MiddlewaresPass#2476
Merged
norberttech merged 1 commit intoJun 22, 2026
Conversation
…DoctrineBundle's MiddlewaresPass Both passes run at TYPE_BEFORE_OPTIMIZATION priority 0, so Symfony executes them in insertion order. When DoctrineBundle is registered before FlowTelemetryBundle (likely to be a common case), MiddlewaresPass scans for doctrine.middleware tags before DBALTelemetryPass has registered the tracing middleware, silently producing no DBAL spans despite the service appearing correctly in debug:container. Raising DBALTelemetryPass to priority 10 ensures it always runs first, regardless of bundle registration order.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #2476 +/- ##
=========================================
Coverage 85.18% 85.18%
Complexity 21432 21432
=========================================
Files 1622 1622
Lines 66195 66195
=========================================
Hits 56389 56389
Misses 9806 9806 🚀 New features to boost your workflow:
|
Member
|
Thank you! I'm going to add some extra tests in the next PR to cover this change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both passes run at TYPE_BEFORE_OPTIMIZATION priority 0, so Symfony executes them in insertion order.
When DoctrineBundle is registered before FlowTelemetryBundle (likely to be a common case), MiddlewaresPass scans for doctrine.middleware tags before DBALTelemetryPass has registered the tracing middleware, silently producing no DBAL spans despite the service appearing correctly in debug:container.
Raising DBALTelemetryPass to priority 10 ensures it always runs first, regardless of bundle registration order.
Resolves: #xxx
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security